Closed Bug 561619 Opened 15 years ago Closed 15 years ago

JS CTypes has a build dependency bug

Categories

(Core :: js-ctypes, defect)

Product:
Core
Component:
js-ctypes
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
blocking2.0 --- beta1+

People

(Reporter: sayrer, Assigned: dwitte)

References

Details

Attachments

(1 file)

patch
(deleted), patch
sayrer
: review+
Details | Diff | Splinter Review
Last night, I merged two perfectly green trees, TM and M-C, and got tons of CTypes crashes in jsdtoa.cpp. After a clobber, it was all fine.
Robert, So are you saying that landing patch part 2 or bug# 549532 should be fine after a "clobber"? Please explain what a clobber is...Thanks. Mike M.
That is... very strange. I'm not sure if I'll be able to tell anything from the logs, but I'll look.
Confirmed. On a hunch I touched jsdtoa.h and rebuilt; the ctypes objects don't get remade. I think the js/src/Makefile.in just needs more VPATH.
(This also explains why I could never reproduce it in my local debugging. Yay dependency bugs!)
Attached patch patch (deleted) — — Splinter Review
This looks like it fixes it. Clobbering works; make clean && make works; touch jsdtoa.h && make works. Tryserver's chewing on it now, to make sure it doesn't break any existing dep builds.
Attachment #441388 - Flags: review?(sayrer)
Note that this will result in orphaned obj files in js/src/ctypes, but they're harmless and will be cleaned up on the next clobber.
Attachment #441388 - Flags: review?(sayrer) → review+
(In reply to comment #1) > Robert, > > So are you saying that landing patch part 2 or bug# 549532 should be fine after > a "clobber"? Please explain what a clobber is...Thanks. A clobber is when we delete all existing object files and rebuild everything from scratch. Your patch just touched lots of files, so tickled this bug. After dwitte's fix lands, it should be clean.
That explains why dtoa.c still crashed after backing out my patch.
Blocks: 560358
Pushed to tracemonkey. Apologies to everyone who spent time looking at this; it went unfound for too long. I'm glad it was finally nailed down.
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: