Closed Bug 56182 Opened 24 years ago Closed 2 years ago

stack overflow in frame construction

Categories

(Core :: Layout, defect, P3)

Product:
Core
Component:
Layout
Platform:
All
Windows 2000
Type:
defect

Tracking

()

Status:
RESOLVED WORKSFORME
Milestone:
mozilla1.2alpha

People

(Reporter: rickg, Unassigned)

References

(
URL
)

Details

The layout system uses a recursive stack-based model for frame construction which can blowup on mac after a depth of 75. For RTM, we've hacked around the problem by prevented excessively deep trees from being stored in the content model (via the parser). This is ugly. The right answer is to eliminate the stack limitation in frame construction. We can 1) use a linear rather than recursive technique; 2) switch to heap allocation for our data structures after a certain depth (1..n); 3) switch to arenas; 4) other? In any event, this should be fixed post RTM. Bad dog -- no biscuit.
*** Bug 42138 has been marked as a duplicate of this bug. ***
Blocks: 42138
Reassigning to harishd.
Assignee: rickg → harishd
Nominating for beta
Keywords: nsbeta1
This should be handled in the layout. --> Mark.
Assignee: harishd → attinasi
OK - accepting
Status: NEW → ASSIGNED
Blocks: 104166
Target Milestone: --- → mozilla1.0
Target Milestone: mozilla1.0 → mozilla1.2
Blocks: 51138
Blocks: 160555
Blocks: 156359
No longer blocks: 51138
*** Bug 51138 has been marked as a duplicate of this bug. ***
*** Bug 156359 has been marked as a duplicate of this bug. ***
Assignee: attinasi → nobody
Status: ASSIGNED → NEW
QA Contact: chrispetersen → layout
QA Whiteboard: qa-not-actionable

For the most part we limit frame tree depth in other ways now. Reflow also is recursive, so we need to limit frame tree depth there and other engines do the same. If we want to revisit it we'd need to re-evaluate this a bit more.

Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.