Closed Bug 562877 Opened 14 years ago Closed 14 years ago

addons manager rewrite re-used entity names with different values

Categories

(Toolkit :: Add-ons Manager, defect, P1)

Product:
Toolkit
Component:
Add-ons Manager
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla1.9.3a5

People

(Reporter: Pike, Assigned: Unfocused)

References

(
URL
)

Details

(Whiteboard: [AddonsRewriteTestday][rewrite])

Attachments

(1 file)

Patch v1
(deleted), patch
mossop
: review+
Details | Diff | Splinter Review 
The addons manager rewrite changed some strings to show up with different values, breaking how we do l10n.

Basically, all that is black on https://l10n-stage-sj.mozilla.org/shipping/diff?from=e716b9e1cfa9&to=4eb27434a297&repo=mozilla-central is wrong (the explicit positioning, not, ok)

This is bad in particular as the changed strings are actually the ones that are now busting the nightlies, so the l10n dashboard can't even tell them what's wrong.
Blocks: 550048
Whiteboard: [AddonsRewriteTestday][rewrite]
Attached patch Patch v1 (deleted) — — Splinter Review 
Assignee: nobody → bmcbride
Status: NEW → ASSIGNED

        Attachment #442804 -
        Flags: review?(dtownsend)

    
    

    
  
Comment on attachment 442804 [details] [diff] [review]
Patch v1

Don't forget to remove the reference to brand.dtd that got added last night.

        Attachment #442804 -
        Flags: review?(dtownsend) → review+

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/3370b99a2196
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Flags: in-testsuite-
Flags: in-litmus-
Resolution: --- → FIXED

    
    

    
  
Landed on branch: http://hg.mozilla.org/projects/addonsmgr/rev/db0565e94760
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Whiteboard: [AddonsRewriteTestday][rewrite] → [AddonsRewriteTestday][rewrite][fixed-in-addonsmgr][needs-landing]
Priority: -- → P1
Blocks: 562894

    
    

    
  
http://hg.mozilla.org/mozilla-central/rev/381653b6c289
Status: REOPENED → RESOLVED
Closed: 14 years ago → 14 years ago
Resolution: --- → FIXED
Whiteboard: [AddonsRewriteTestday][rewrite][fixed-in-addonsmgr][needs-landing] → [AddonsRewriteTestday][rewrite]
Target Milestone: --- → mozilla1.9.3a5

    
    

    
  
Verified fixed with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.3a5pre) Gecko/20100517 Minefield/3.7a5pre (.NET CLR 3.5.30729)
Status: RESOLVED → VERIFIED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: