Peter van der Woude [:Peter6] Reporter
	Description • 14 years ago

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.3a5pre) Gecko/20100430 Minefield/3.7a5pre ID:20100430040256

repro:
open yesterdays build
install AdblockPlus
restart and close

open todays build
go to the new add-ons manager
check for updates
the newer Adblockplus installes
restart FF
open AM 

result:
no AdblockPlus in the list

I'm notsure this needs the kwd "regression"

	Henrik Skupin [:whimboo][⌚️UTC+2]
	Comment 1 • 14 years ago

Peter, which version of Adblock Plus you had installed before?

	Peter van der Woude [:Peter6] Reporter
	Comment 2 • 14 years ago

I had 1.1.3 and the update was to 1.2

Oddly enough Adblock Plus was totally gone, even when I reverted to yesterdays build (before new add-ons manager)

	Henrik Skupin [:whimboo][⌚️UTC+2]
	Comment 3 • 14 years ago

Can you also reproduce it in a fresh profile? If yes, it would be helpful when you could attach the extensions.sqlite file.

	Peter van der Woude [:Peter6] Reporter
	Comment 4 • 14 years ago

Yep, same with new profile.

	Gabriela [:gaby2300]
	Comment 5 • 14 years ago

Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.3a5pre) Gecko/20100430 Minefield/3.7a5pre

I installed NoSript and after restarting the addon's tab site showed on focus. There it said I had to update to the latest version so I did via the site's link. This time the addon's tab site did not appear at all, the addon was not listed on the Addons Manager Tab but I can see it's icon on the status bar!!!
NoScript is installed though, because I have the icon on the statusbar and right clicking it I get the context menu with all the options.

	Tiago Sá
	Comment 7 • 14 years ago

The same thing happened to me on the latest build (actually, yesterday's) but it didn't disappear from the list, it actually uninstalled completely. It was still there after the restart (not on the list though), but after a second restart (to see if it made a difference) it wasn't anywhere to be found.

	Dave Townsend [:mossop] Assignee
	Comment 8 • 14 years ago

I haven't been able to reproduce updates flat out uninstalling versions. I have seen a case where an update didn't properly apply, I'll take care of that in bug 564030. It's possible though I think unlikely that the two are related though.

Can people who have seen this get one of the old nightlies with the add-ons manager still in it and enable extensions.logging.enabled and see what messages are in the error console after the restart that was meant to install the updated version.

	Dave Townsend [:mossop] Assignee
	Comment 9 • 14 years ago

(In reply to comment #6)
> Created an attachment (id=442855) [details]
> NoSript is not listed on the Addons Manager Tab but it is installed because I
> see the icon on the status bar

This is bug 566626 I think

	Dave Townsend [:mossop] Assignee
	Comment 10 • 14 years ago

Peter, are you still seeing this?

	Peter van der Woude [:Peter6] Reporter
	Comment 11 • 14 years ago

Dave, my laptop died and is not fixed yet so I can't test it..
I don't want to try trunk with my underpowerd EEE.

	Wladimir Palant
	Comment 14 • 14 years ago

I just reproduced this issue on a clean profile updating from https://adblockplus.org/devbuilds/adblockplus/adblockplus-1.2.0+.2010050102.xpi to latest development build - no custom settings whatsoever, Adblock Plus is the only extension installed. Restarting after update removes all extension files except chrome/adblockplus.jar. After second update this file (and the entire extension directory) is removed as well, Adblock Plus is still listed in extensions.ini however.

	Gary King
	Comment 15 • 14 years ago

If it is a duplicate, the bug was not fixed.

	Wladimir Palant
	Comment 16 • 14 years ago

Sorry, meant to say "After second restart" above.

@Gary: no, this bug isn't marked as fixed.

	Gary King
	Comment 17 • 14 years ago

Thanks Wladimir

	Gary King
	Comment 18 • 14 years ago

The same thing has just happened when I tried to update Noscript. You can see that it is in the status bar but it is not in the extension list:

[URL=http://s20.photobucket.com/albums/b243/TK-1913/?action=view&current=ns.png][IMG]http://i20.photobucket.com/albums/b243/TK-1913/th_ns.png[/IMG][/URL]

	Gary King
	Comment 19 • 14 years ago

http://i20.photobucket.com/albums/b243/TK-1913/ns.png

The above should go with Comment 18

	Dave Townsend [:mossop] Assignee
	Comment 20 • 14 years ago

(In reply to comment #18)
> The same thing has just happened when I tried to update Noscript. You can see
> that it is in the status bar but it is not in the extension list:
> 
> [URL=http://s20.photobucket.com/albums/b243/TK-1913/?action=view&current=ns.png][IMG]http://i20.photobucket.com/albums/b243/TK-1913/th_ns.png[/IMG][/URL]

If you see NoScript reappear after switching between the themes and extensions list a few times and it isn't getting uninstalled after a restart then you are probably seeing bug 566626

	Gary King
	Comment 21 • 14 years ago

Probably but I tried to do that and it did not work. It seems that these two extensions are the only ones I am having issues with. Maybe the AOM is trying to update them form-about:addons- and when it sees that there is a lower version there, it goes wacky?? Just a thought.

	Henrik Skupin [:whimboo][⌚️UTC+2]
	Comment 22 • 14 years ago

Yes, NoScript is bug 566626.

	Antti Tervasmäki
	Comment 24 • 14 years ago

(In reply to comment #18)
> The same thing has just happened when I tried to update Noscript. You can see
> that it is in the status bar but it is not in the extension list:

At least for me that is the old version which was supposed to be updated. After second restart it is gone (totally uninstalled) Errors from error console are in comment 23...

	Adrian
	Comment 25 • 14 years ago

I

	Adrian
	Comment 26 • 14 years ago

I am using 1.3a and i have not see this problems, try to update it to 1.3a

	Gary King
	Comment 27 • 14 years ago

Adrian, Use an older release of ABP, then try to update it.

	Giorgio Maone [:ma1]
	Comment 28 • 14 years ago

(In reply to comment #22)
> Yes, NoScript is bug 566626.

Nope, both ABP and NoScript are affected by this very bug (see attachment #446713 [details]), while extensions with no JS components (like https://addons.mozilla.org/it/firefox/addon/4270 ) seem to be unaffected.

To recap, both if you reinstall the extension over itself (even the same version) or you use automatic update, the extension:
 
1) On first browser restart, breaks -- chrome from previous installation is retained but JS components are not register anymore
2) On second browser restart gets completely uninstalled

	Gary King
	Comment 29 • 14 years ago

To comment 28 by Giorgio Maone. 

You are correct.

	Gary King
	Comment 30 • 14 years ago

I just updated my addons and Noscript vanished once again. I had to re install it to get it back as being shown as an addon. The Icons in the status bar stayed.

	Gary King
	Comment 31 • 14 years ago

This happened to me twice today. Once when I updated Noscript and once when I updated Adblock Plus. I had to reinstall both extensions.

	Gary King
	Comment 32 • 14 years ago

Could you please assign this too someone to fix?

	Robert Strong (they/them - no direct email)
	Comment 33 • 14 years ago

Gary, we won't ship with this serious of a bug and someone (most likely Dave Townsend) will take this bug when he has the time to work on it.

	Gary King
	Comment 34 • 14 years ago

OK , I just thought that a bug that effects two of Firefox's most used extensions and are related to security, would at least be assigned to someone by now. I know that this bug will not ship and hopefully none of them will.

	Dave Townsend [:mossop] Assignee
	Comment 35 • 14 years ago

This is pretty much what I expected. The extension to be updated is loading during startup which leaves some files locked so when we try to remove it to do the update we fail. This might be improved with bug 553015, but the nice thing that I've been wanting to do and fixes this anyway is to remove add-ons pending upgrade from the extensions.ini list. This means the platform will not load them on the next startup so we are free to replace their files.

	Robert Strong (they/them - no direct email)
	Comment 36 • 14 years ago

Comment on attachment 447790 [details] [diff] [review]
patch rev 1

>diff --git a/toolkit/mozapps/extensions/XPIProvider.jsm b/toolkit/mozapps/extensions/XPIProvider.jsm
>--- a/toolkit/mozapps/extensions/XPIProvider.jsm
>+++ b/toolkit/mozapps/extensions/XPIProvider.jsm
>...
>@@ -3261,47 +3271,55 @@ var XPIDatabase = {
> 
>   /**
>    * Synchronously calculates and updates all the active flags in the database.
>    */
>   updateActiveAddons: function XPIDB_updateActiveAddons() {
>     LOG("Updating add-on states");
>     let stmt = this.getStatement("setActiveAddons");
>     stmt.execute();
>-
>-    this.writeAddonsList();
>   },
> 
>   /**
>    * Writes out the XPI add-ons list for the platform to read.
>-   */
>-  writeAddonsList: function XPIDB_writeAddonsList() {
>+   *
>+   * @param  aPendingUpdateIDs
>+   *         A list of IDs of add-ons that are pending update and so shouldn't
>+   *         be included in the add-ons list.
s/A list/An array/

btw: cool solution.

	Dave Townsend [:mossop] Assignee
	Comment 37 • 14 years ago

Landed: http://hg.mozilla.org/mozilla-central/rev/20d24f34a512

	Henrik Skupin [:whimboo][⌚️UTC+2]
	Comment 38 • 14 years ago

Looks to work fine now with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.3a5pre) Gecko/20100530 Minefield/3.7a5pre (.NET CLR 3.5.30729)

Gary and Wladimir, can you please test again and give feedback if it also works for you? Thanks.

	Gary King
	Comment 39 • 14 years ago

I cannot get to the add-on site by pressing the Get add on button.

http://i20.photobucket.com/albums/b243/TK-1913/gao.png

	Dave Townsend [:mossop] Assignee
	Comment 40 • 14 years ago

(In reply to comment #39)
> I cannot get to the add-on site by pressing the Get add on button.
> 
> http://i20.photobucket.com/albums/b243/TK-1913/gao.png

That doesn't seem related to this bug report, please file a new bug with more details about what your problem it.

	Wladimir Palant
	Comment 41 • 14 years ago

I can confirm that everything works as expected in this build:

Mozilla/5.0 (Windows; U; Windows NT 6.1; WOW64; en-US; rv:1.9.3a5pre) Gecko/20100530 Minefield/3.7a5pre

I tried installing and updating an Adblock Plus development build as before.

	Henrik Skupin [:whimboo][⌚️UTC+2]
	Comment 42 • 14 years ago

Thanks for your feedback. Marking as verified fixed.