Closed Bug 562997 Opened 15 years ago Closed 15 years ago

[OOPP] Unsupported NPEventsOSX are serialized.

Categories

(Core Graveyard :: Plug-ins, defect)

x86
macOS
defect
Not set
major

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: BenWa, Assigned: jaas)

Details

Attachments

(1 file)

I get the following error repeatedly in the console with some interactive flash game. This error can not be ignored: ###!!! [Child][RPCChannel] Error: Payload error: message could not be deserialized
STR: Click in and out of a Flash object frame several times.
The problem is that we are serializing an event with the type 0. I'm going to set up a debug build to see what part of the code is trying to serialize an invalid event.
The problem is coming from: http://mxr.mozilla.org/mozilla-central/source/layout/generic/nsObjectFrame.cpp#4429 We never set the cocoa event for NS_FOCUS_CONTENT/NS_BLUR_CONTENT messages. I'm guessing this is supposed to map to a "NPCocoaEventFocusChanged"? Is there a reason why this is not implement as a cocoa event? We should either build a valid cocoa event to pass to the plug-in or not pass anything at all.
Assignee: nobody → joshmoz
Attached patch fix v1.0 (deleted) — Splinter Review
Attachment #443162 - Flags: review?(roc)
We could test for this sort of thing by having the test plugin somehow fail whenever it gets an unrecognizable event. Maybe crash on purpose.
We already assert that this should not happen: http://mxr.mozilla.org/mozilla-central/source/dom/plugins/NPEventOSX.h#107. cjones mentioned that these errors would become no longer be ignored and would become 'critical' in the near future. It might be worth while checking with him first exactly what behavior will be implemented.
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: