Closed
Bug 563971
Opened 14 years ago
Closed 14 years ago
When migrating with a lightweight theme enabled the default theme will think it is enabled
Categories
(Toolkit :: Add-ons Manager, defect, P2)
Toolkit
Add-ons Manager
Tracking
()
VERIFIED
FIXED
mozilla2.0b7
Tracking | Status | |
---|---|---|
blocking2.0 | --- | beta7+ |
People
(Reporter: mossop, Assigned: mossop)
References
Details
(Whiteboard: [rewrite][has patch])
Attachments
(1 file)
(deleted),
patch
|
robert.strong.bugs
:
review+
|
Details | Diff | Splinter Review |
When a lightweight theme is enabled the default theme should be marked as userDisabled but during migration we won't check on the lightweight themes when deciding on the value of userDisabled for the default theme.
Comment 1•14 years ago
|
||
For a testcase see attachment 442850 [details].
Assignee | ||
Updated•14 years ago
|
blocking2.0: --- → beta1+
Assignee | ||
Updated•14 years ago
|
Assignee: dtownsend → nobody
Assignee | ||
Updated•14 years ago
|
blocking2.0: beta1+ → final+
Assignee | ||
Updated•14 years ago
|
blocking2.0: final+ → beta2+
Assignee | ||
Updated•14 years ago
|
Assignee: nobody → dtownsend
Assignee | ||
Updated•14 years ago
|
blocking2.0: beta2+ → final+
Assignee | ||
Updated•14 years ago
|
Assignee | ||
Comment 6•14 years ago
|
||
I dislike having to make the providers talk like this but this really is the simplest fix.
Attachment #477785 -
Flags: review?(robert.bugzilla)
Assignee | ||
Updated•14 years ago
|
Status: NEW → ASSIGNED
Whiteboard: [rewrite] → [rewrite][has patch]
![]() |
||
Comment 7•14 years ago
|
||
Comment on attachment 477785 [details] [diff] [review] patch rev 1 >diff --git a/toolkit/mozapps/extensions/XPIProvider.jsm b/toolkit/mozapps/extensions/XPIProvider.jsm >--- a/toolkit/mozapps/extensions/XPIProvider.jsm >+++ b/toolkit/mozapps/extensions/XPIProvider.jsm >@@ -509,21 +510,25 @@ function loadManifestFromRDF(aUri, aStre > } > else { > platform.os = aPlatform; > } > > addon.targetPlatforms.push(platform); > }); > >- // Themes are disabled by default unless they are currently selected >- if (addon.type == "theme") >- addon.userDisabled = addon.internalName != XPIProvider.selectedSkin; >- else >+ // Themes are disabled if they aren't the selected skin or there is an active >+ // lightweight theme nit: the wording here made me think that if there is an active lightweight theme a theme is disabled. Perhaps // A theme's userDisabled value is true if the theme is not the selected skin or the theme is a lightweight theme and it isn't the current lightweight theme. Might be a good thing to make a note somewhere that themes can't be softblocked.
Attachment #477785 -
Flags: review?(robert.bugzilla) → review+
Assignee | ||
Comment 9•14 years ago
|
||
Landed for b7: http://hg.mozilla.org/mozilla-central/rev/626d22af7eff Note that this wont actually correct the problem if the user has already migrated their DB, they'll need to just switch to a new theme to fix it.
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Flags: in-testsuite+
Flags: in-litmus-
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b7
Comment 10•14 years ago
|
||
Verified fixed with Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b8pre) Gecko/20101010 Firefox/4.0b8pre
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•