Closed
Bug 564026
Opened 15 years ago
Closed 15 years ago
[OS/2] still linking problems for shared builds after integration of layers into thebes
Categories
(Core :: Graphics, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: wuno, Assigned: wuno)
References
Details
Attachments
(2 files, 1 obsolete file)
(deleted),
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (OS/2; U; Warp 4.5; en-US; rv:1.9.3a5pre) Gecko/20100505 SeaMonkey/2.1a1pre
Build Identifier:
Building Seamonkey after checkin for Bug560147
weakld: error: Unresolved symbol (UNDEF) '__ZN7mozilla6layers17BasicLayerManager16SetDefaultTargetEP10gfxContext'.
weakld: info: The symbol is referenced by:
E:\mozbuild4\mozilla\widget\src\xpwidgets\xpwidgets_s.lib(nsBaseWidget.o)
weakld: error: Unresolved symbol (UNDEF) '__ZN7mozilla6layers17BasicLayerManagerC1EP10gfxContext'.
weakld: info: The symbol is referenced by:
E:\mozbuild4\mozilla\widget\src\xpwidgets\xpwidgets_s.lib(nsBaseWidget.o)
weakld: error: Unresolved symbol (UNDEF) '__ZN7mozilla6layers15LayerManagerOGL10InitializeEv'.
weakld: info: The symbol is referenced by:
E:\mozbuild4\mozilla\widget\src\xpwidgets\xpwidgets_s.lib(nsBaseWidget.o)
weakld: error: Unresolved symbol (UNDEF) '__ZN7mozilla6layers15LayerManagerOGLC1EP9nsIWidget'.
weakld: info: The symbol is referenced by:
E:\mozbuild4\mozilla\widget\src\xpwidgets\xpwidgets_s.lib(nsBaseWidget.o)
Ignoring unresolved externals reported from weak prelinker.
...
weakld: error: Unresolved symbol (UNDEF) '__ZN7mozilla6layers17BasicLayerManagerC1EP10gfxContext'.
weakld: info: The symbol is referenced by:
E:\mozbuild4\mozilla\layout\base\gkbase_s.lib(nsDisplayList.o)
E:\mozbuild4\mozilla\content\html\content\src\gkconhtmlcon_s.lib(nsHTMLMediaElement.o)
Ignoring unresolved externals reported from weak prelinker.
E:\mozbuild4\mozilla\content\html\content\src\gkconhtmlcon_s.lib(nsHTMLMediaElement.o) : error LNK2029: "mozilla::layers::BasicLayerManager::BasicLayerManager(gfxContext*)" : unresolved external
E:\mozbuild4\mozilla\layout\base\gkbase_s.lib(nsDisplayList.o) : error LNK2029: "mozilla::layers::BasicLayerManager::BasicLayerManager(gfxContext*)" : unresolved external
It appears that the BasicLayerManager and LayerManagerOGL symbols are not properly exported, though the respective headers are included in the new file for symbol export gfx/thebes/src/gfxDllDeps.cpp and though the classes are declared as THEBES_API (which should trigger __declspec(dllexport)). The missing symbols are also not in thebes.map
Reproducible: Always
Assignee | ||
Comment 1•15 years ago
|
||
Probably not what is wanted, but works
I wonder why Windows hasn't the same linking problems
Assignee: nobody → wuno
Status: NEW → ASSIGNED
Comment 2•15 years ago
|
||
(In reply to comment #1)
> Created an attachment (id=443720) [details]
> preliminary fix
>
> Probably not what is wanted, but works
> I wonder why Windows hasn't the same linking problems
I believe in windows we get it with SHARED_LIBRARY_LIBS? Atleast that's what I thought.
Assignee | ||
Comment 3•15 years ago
|
||
similar to the other dlldeps files in the tree (in toolkit/library/ or modules/zlib). Adding dummy functions that are not dllexported by inclusion of the header files to gfxdlldeps exports the missing symbols from thebes.dll. Could ifdef XP_OS2 the added lines if wanted.
Attachment #443720 -
Attachment is obsolete: true
Attachment #444321 -
Flags: review?(ted.mielczarek)
Updated•15 years ago
|
Attachment #444321 -
Flags: review?(ted.mielczarek) → review+
Assignee | ||
Comment 4•15 years ago
|
||
Assignee | ||
Updated•15 years ago
|
Attachment #446036 -
Attachment is patch: true
Attachment #446036 -
Attachment mime type: application/octet-stream → text/plain
Assignee | ||
Updated•15 years ago
|
Keywords: checkin-needed
Comment 5•15 years ago
|
||
Keywords: checkin-needed
Updated•15 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•