Martijn Wargers (dead) Reporter
	Description • 14 years ago

To reproduce, go to about:addons, then try to print or print preview.

Actual result:
You get "an unexpected error occured while printing" error dialog.

Expected result:
Print preview or a print dialog should come up or you shouldn't be able to print/print preview from the menu.

	Blair McBride [:Unfocused] (UNAVAILABLE)
	Comment 1 • 14 years ago

Wonder if we should just disable Print/Print Preview for all about: pages.

	Henrik Skupin [:whimboo][⌚️UTC+2]
	Comment 2 • 14 years ago

It's a general problem for about: pages. So moving over to Core:Printing.

	Martijn Wargers (dead) Reporter
	Comment 3 • 14 years ago

It's not a general problem for about: pages, it's because the about: pages are xul documents.

	Boris Zbarsky [:bzbarsky]
	Comment 4 • 14 years ago

Yep.  We have no support for printing XUL.

	Jennifer Morrow [:Boriss] (UX)
	Comment 5 • 14 years ago

Let's take the consistent behavior and disable/fade out the print menu while in the add-ons manager, as we do for the Library, Download Manager, etc.

	Henrik Skupin [:whimboo][⌚️UTC+2]
	Comment 6 • 14 years ago

Shall we move this bug back to Addons Manager and file a new one for the underlying issue? Or do we already have one on file?

	Blair McBride [:Unfocused] (UNAVAILABLE)
	Comment 7 • 14 years ago

This is really just a browser problem - the menu items (and commands in general) for printing (and possibly other commands too?) should be disabled for such about: pages.

	Steffen Wilberg
	Comment 8 • 14 years ago

Most pages listed on about:about work, just the XUL pages like about:addons and about:config don't.

	Blair McBride [:Unfocused] (UNAVAILABLE)
	Comment 9 • 14 years ago

(In reply to comment #8)
> Most pages listed on about:about work, just the XUL pages like about:addons and
> about:config don't.

I think printing should also be disabled for pages that can print but make no sense to print. eg, printing about:blank is never going to be useful; neither is saving it.

	Asaf Romano (gone)
	Comment 10 • 14 years ago

Unless, that about:blank page has content...

It's not a matter of "sense".  We should disable print for pages that we cannot print - meaning any xul page (not just about/chrome).

	ametedinov
	Comment 12 • 14 years ago

Support for printing about pages and especially about:config not only should but MUST be available. It is essential for many of the tasks I would do if I could print that page.

	Asaf Romano (gone)
	Comment 13 • 14 years ago

ametedinov@gmail.com : Please avoid useless comments.  If you want to be able to print XUL pages (that includes about:config), look for that bug on that.  This one is just about disabling the UI commands for pages which cannot be printed.

	Dão Gottwald [:dao]
	Comment 15 • 14 years ago

Comment on attachment 463352 [details] [diff] [review]
the patch

>+    if (content.document && mimeTypeIsTextBased(content.document.contentType)) {
>+      this.isImage.removeAttribute('disabled');
>+      if (content.document instanceof XULDocument)
>+        this.isPrintable.setAttribute('disabled', 'true');
>+      else
>+        this.isPrintable.removeAttribute('disabled');
>+    }
>+    else {
>+      this.isImage.setAttribute('disabled', 'true');
>+      this.isPrintable.removeAttribute('disabled');
>+    }

This wrongly disables printing for standalone images.

nits: s/updateBroadcasters/_updateBroadcasters/ and double quotes instead of single quotes?

	Dão Gottwald [:dao]
	Comment 16 • 14 years ago

Comment on attachment 463352 [details] [diff] [review]
the patch

Ugh, I misread the code, there shouldn't be a problem with images. Maybe rename isPrintable to printCommands, as printCommands.removeAttribute("disabled") etc. better matches natural language...

	JP Rosevear [:jpr]
	Comment 18 • 14 years ago

Comment on attachment 463352 [details] [diff] [review]
the patch

Never landed.

	(no longer active)
	Comment 19 • 13 years ago

This doesn't apply cleanly on trunk any more.

	Worcester12345
	Comment 20 • 7 years ago

I am seeing this bug. 

Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:56.0) Gecko/20100101 Firefox/56.0 ID:20170918210324

There is a patch for this. Can it be checked and fixed?

	Boris Zbarsky [:bzbarsky]
	Comment 21 • 7 years ago

> There is a patch for this.

Which doesn't apply on trunk, right?  See comment 19.

	Worcester12345
	Comment 22 • 7 years ago

(In reply to Boris Zbarsky [:bz] (still digging out from vacation mail) from comment #21)
> > There is a patch for this.
> 
> Which doesn't apply on trunk, right?  See comment 19.

Perhaps someone can update it so it DOES apply correctly. Thanks.