Closed
Bug 565521
Opened 15 years ago
Closed 15 years ago
TM: foreach loops need to call the getter on the original object instead of the prototype
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: mrbkap, Assigned: mrbkap)
References
Details
(Whiteboard: fixed-in-tracemonkey)
Attachments
(2 files)
|
(deleted),
patch
|
gal
:
review+
|
Details | Diff | Splinter Review |
|
(deleted),
patch
|
sayrer
:
review+
|
Details | Diff | Splinter Review |
This is the bug in test_feed_discovery.html: we're calling the getter on the (XPCWrappedNative) prototype instead of the wrappednative itself and XPConnect can't deal. Easy fix upcoming.
|
Assignee | |
Comment 1•15 years ago
|
||
|
||
Updated•15 years ago
|
Attachment #445012 -
Flags: review?(gal) → review+
|
|
||
Updated•15 years ago
|
Version: 1.9.1 Branch → Trunk
|
|
Assignee | |
Comment 2•15 years ago
|
||
Whiteboard: fixed-in-tracemonkey
|
||
Comment 3•15 years ago
|
||
Comment on attachment 445012 [details] [diff] [review]
Fix
Argh. I so should have caught this, it's the elephant in the room.
/be
|
||
Comment 4•15 years ago
|
||
this needs a test for this specific problem in trace-tests or js-reftests.
|
|
Assignee | |
Comment 5•15 years ago
|
||
Attachment #445024 -
Flags: review?(sayrer)
|
|
||
Updated•15 years ago
|
Attachment #445024 -
Flags: review?(sayrer) → review+
|
|
Assignee | |
Comment 6•15 years ago
|
||
Flags: in-testsuite+
|
|
||
Comment 7•15 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•