Current Windows build processes give the following error when building the uninstaller: Invalid command: ${UpdateShortcutAppModelIDs} Error in macro UninstallOnInitCommon on macroline 53 Error in script "uninstaller.nsi" on line 130 -- aborting creation process Looks like this is coming from http://hg.mozilla.org/mozilla-central/rev/a24884c8140a for bug 562753 or http://hg.mozilla.org/mozilla-central/rev/2074183c0d6c for bug 521141 (which are closely related and landed in the same push anyhow.

This should be easy to fix by adding !insertmacro UpdateShortcutAppModelIDs to the uninstaller.nsi script. Let me see if I can work up a patch.

jimm, thanks for looking into that. If we fix the bustage by that, we'll still want a bug to actually port the other stuff (given that we want to support Win7 well), right?

Comment on attachment 445561 [details] [diff] [review] patch There's no Vendor in Thunderbird's application.ini.

Comment on attachment 445561 [details] [diff] [review] patch Jim, this looks fine but I'm not a SeaMonkey or Thunderbird peer so you will need to get someone that is to r+ it which is why I changed it feedback+

Comment on attachment 445561 [details] [diff] [review] patch r=me for the suite/ parts.

(In reply to comment #8) > http://hg.mozilla.org/comm-central/rev/1d899bd49d9e Well theoretically, my review was only for the suite/ parts and not for the mail/ parts, but I'm sure the Thunderbird team won't be sad that their builds got fixed with this checkin ;-)

Comment on attachment 445561 [details] [diff] [review] patch Assuming TB considers my "Build-Config" peer status as applying to [un]installer adding a r+ just for future-sake. Reviewed after the fact.