Closed
Bug 566485
Opened 14 years ago
Closed 14 years ago
Changes made to the list of bootstrapped extensions during startup are lost if an EM restart is necessary
Categories
(Toolkit :: Add-ons Manager, defect, P1)
Toolkit
Add-ons Manager
Tracking
()
VERIFIED
FIXED
mozilla1.9.3a5
| Tracking | Status | |
|---|---|---|
| blocking2.0 | --- | beta1+ |
People
(Reporter: mossop, Assigned: mossop)
References
Details
(Whiteboard: [rewrite])
Attachments
(1 file)
|
(deleted),
patch
|
robert.strong.bugs
:
review+
|
Details | Diff | Splinter Review |
If a new bootstrapped extension is detected during startup we call its install method, but if we then EM restart because of other extension changes we never call startup on the next start of the app.
|
Assignee | |
Comment 1•14 years ago
|
||
We should write the bootstrap list pref on every shutdown, not just the one that only runs when we have started up bootstrapped add-ons. Also clears some members that I neglected to.
Attachment #445852 -
Flags: review?(robert.bugzilla)
|
||
Updated•14 years ago
|
Attachment #445852 -
Flags: review?(robert.bugzilla) → review+
|
|
||
Comment 2•14 years ago
|
||
Comment on attachment 445852 [details] [diff] [review]
patch rev 1
Makes sense
|
|
Assignee | |
Comment 3•14 years ago
|
||
Pushed to trunk: http://hg.mozilla.org/mozilla-central/rev/edd9b0350ea6
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a5
|
||
Comment 4•14 years ago
|
||
Dave, is the automated test which has been already checked-in enough for coverage or would you also like to see a manual test?
Flags: in-testsuite+
Flags: in-litmus?
|
|
||
Comment 6•14 years ago
|
||
Looks like the automated test works well and nothing has been broken with this patch. Marking as verified fixed.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•