Closed
Bug 566613
Opened 14 years ago
Closed 14 years ago
Typo "wasVisbile" in treeView.js
Categories
(Firefox :: Bookmarks & History, defect)
Tracking
()
RESOLVED
FIXED
Firefox 3.7a5
People
(Reporter: kairo, Assigned: kairo)
References
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
asaf
:
review+
|
Details | Diff | Splinter Review |
The review in bug 547815 comment #24 found a typo "wasVisbile" in treeView.js, we should also fix that on the Firefox side.
|
Assignee | |
Comment 1•14 years ago
|
||
This patch fixes that typo, as well as a small whitespace nit and an invisible node lookup noted by Neil in the other bug.
Attachment #446924 -
Flags: review?(mano)
|
|
Assignee | |
Comment 2•14 years ago
|
||
Sorry, the first version of this bug caused things to break. We still need to keep parent defined as it's being used in a few other places in that function.
Attachment #446924 -
Attachment is obsolete: true
Attachment #447520 -
Flags: review?(mano)
Attachment #446924 -
Flags: review?(mano)
|
||
Comment 3•14 years ago
|
||
Comment on attachment 447520 [details] [diff] [review]
v1.1: keep parent defined
r=mano
Attachment #447520 -
Flags: review?(mano) → review+
|
|
Assignee | |
Comment 4•14 years ago
|
||
Thanks, pushed as http://hg.mozilla.org/mozilla-central/rev/8c8d4f75351c
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.7a5
You need to log in
before you can comment on or make changes to this bug.
Description
•