Closed
Bug 566637
Opened 14 years ago
Closed 14 years ago
TM: "this.a" not updated as global variable "a" changes value
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| blocking2.0 | --- | final+ |
People
(Reporter: jruderman, Assigned: jorendorff)
References
Details
(Keywords: regression, testcase, Whiteboard: [fixed-in-tracemonkey])
Attachments
(1 file)
|
(deleted),
patch
|
gal
:
review+
|
Details | Diff | Splinter Review |
js> for (var j = 0; j < 6; ++j) { var a = j; print(this.a); }
0
1
2
2
2
2
|
||
Updated•14 years ago
|
blocking2.0: --- → final+
|
||
Comment 1•14 years ago
|
||
Looks like getthisprop doesn't check for the global object. Dumb. We should fix this with a fast path (guard on global object, and then reach into slots).
|
Reporter | |
Comment 2•14 years ago
|
||
For this particular script, you can tell statically that |this| is the global object and omit the guard, right?
|
|
||
Comment 3•14 years ago
|
||
Yeah, its global code so that should work.
|
||
Comment 4•14 years ago
|
||
autoBisect shows this is probably related to the following changeset:
The first good revision is:
changeset: 40757:c12e3fa489dc
user: Jason Orendorff
date: Mon Apr 12 08:27:16 2010 -0500
summary: Bug 557652 - Eliminate redundant guard that incProp/getProp operand is not the global object. r=brendan.
|
|
||
Comment 5•14 years ago
|
||
... where the first "good" revision means that the number "5" is no longer seen in stdout.
|
||
Comment 6•14 years ago
|
||
Need an owner -- jorendorff, gal, anyone have time?
/be
|
|
||
Updated•14 years ago
|
|
Assignee | |
Comment 8•14 years ago
|
||
Attachment #460343 -
Flags: review?(gal)
|
|
||
Updated•14 years ago
|
Attachment #460343 -
Flags: review?(gal) → review+
|
|
Assignee | |
Comment 9•14 years ago
|
||
Whiteboard: [fixed-in-tracemonkey]
|
|
||
Comment 10•14 years ago
|
||
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
|
||
Comment 12•12 years ago
|
||
Bug in removed tracer code, setting in-testsuite- flag.
Flags: in-testsuite-
You need to log in
before you can comment on or make changes to this bug.
Description
•