Problem is so that gfxPlatformQt creating offscreen surface with gfxXlibSurface(Display* dpy, XRenderPictFormat *format, const gfxIntSize& size); And after that cairo return NULL visual because it is not trying to find visual and set it to xlib_surface structure... http://mxr.mozilla.org/mozilla-central/source/gfx/cairo/cairo/src/cairo-xlib-surface.c#3196 I think we should try to find related visual, and call new gfxXlibSurface(Display *dpy, Visual *visual, const gfxIntSize& size, int depth = 0);

See also http://marc.info/?l=cairo&m=121624409609428&w=2, bug 445250 comment 5

Comment on attachment 446745 [details] [diff] [review] cairo patch, updated to trunk. This patch seems to break plugins rendering

(In reply to comment #3) > This patch seems to break plugins rendering Flash with GTK ports would need DRAW_SUPPORTS_NONDEFAULT_VISUAL to be removed: http://hg.mozilla.org/mozilla-central/annotate/d7ba6aef21eb/layout/generic/nsObjectFrame.cpp#l5135 (I'm not clear on exactly which visuals Flash Player does support; it may only be ARGB visuals causing problems.) I don't know why it would "break" Qt ports.

Comment on attachment 446745 [details] [diff] [review] cairo patch, updated to trunk. Yep, you right... removing non-default visual helps in this situation. And this patch seems to work fine

Oleg, can you try to upstream this patch? There are people on the cairo list that would be better at reviewing this then me.

Bug created: https://bugs.freedesktop.org/show_bug.cgi?id=28492 Message posted to cairo mailing list.

Ok, patch already in cairo upstream ;) http://cgit.freedesktop.org/cairo/commit/?id=55037bfb2454a671332d961e061c712ab5471580

Comment on attachment 446745 [details] [diff] [review] cairo patch, updated to trunk. Looks good. Make sure you add the patch to the cairo directory

due Gdk-CRITICAL **: gdk_x11_visual_get_xvisual http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1276838409.1276840450.21437.gz&fulltext=1 REFTEST INFO | Loading a blank page REFTEST TEST-START | file:///home/cltbld/talos-slave/mozilla-central-fedora-opt-u-crashtest/build/reftest/tests/modules/plugin/test/crashtests/540114-1.html NPP_Destroy NPP_Destroy WARNING: gdk_x11_visual_get_xvisual: assertion `visual != NULL' failed: 'glib warning', file /builds/slave/mozilla-central-linux/build/toolkit/xre/nsSigHandlers.cpp, line 193 (firefox-bin:1997): Gdk-CRITICAL **: gdk_x11_visual_get_xvisual: assertion `visual != NULL' failed WARNING: gdk_x11_colormap_get_xcolormap: assertion `GDK_IS_COLORMAP (colormap)' failed: 'glib warning', file /builds/slave/mozilla-central-linux/build/toolkit/xre/nsSigHandlers.cpp, line 193 (firefox-bin:1997): Gdk-CRITICAL **: gdk_x11_colormap_get_xcolormap: assertion `GDK_IS_COLORMAP (colormap)' failed ###!!! [Parent][RPCChannel] Error: Channel error: cannot send/recv REFTEST TEST-UNEXPECTED-FAIL | file:///home/cltbld/talos-slave/mozilla-central-fedora-opt-u-crashtest/build/reftest/tests/modules/plugin/test/crashtests/540114-1.html | plugin should not crash item 1 REFTEST INFO | Loading a blank page REFTEST TEST-START | file:///home/cltbld/talos-slave/mozilla-central-fedora-opt-u-crashtest/build/reftest/tests/modules/plugin/test/crashtests/570884.html REFTEST TEST-PASS | file:///home/cltbld/talos-slave/mozilla-central-fedora-opt-u-crashtest/build/reftest/tests/modules/plugin/test/crashtests/570884.html | (LOAD ONLY) REFTEST INFO | Loading a blank page REFTEST TEST-START | file:///home/cltbld/talos-slave/mozilla-central-fedora-opt-u-crashtest/build/reftest/tests/parser/htmlparser/tests/crashtests/30885-1.html

I'm guessing that was caused by gfxPlatformGtk::CreateOffscreenSurface using a GdkPixmap with no colormap: http://hg.mozilla.org/mozilla-central/annotate/5f3955a452ac/gfx/thebes/src/gfxPlatformGtk.cpp#l195 One option might be to put a sensible colormap on the surface. Though simpler (and maybe better) would be to just let gfxXlibSurface(Display*, XRenderPictFormat*, const gfxIntSize&) create the pixmap. (Now that the cairo surface has an associated visual, the GdkPixmap wrapper will get added if and only when it is needed.)

I filed bug 573319 on CreateOffscreenSurface.

http://hg.mozilla.org/mozilla-central/rev/ba88e35da4e7 - repeat

reverted in http://hg.mozilla.org/mozilla-central/rev/200f9be1c8e5 due to svg crashtest fail: see bug 573319

Bug 574220 and bug 569775 probably need to be resolved before we can land this.