Closed
Bug 568041
Opened 15 years ago
Closed 14 years ago
More layer API needed for retained layers
Categories
(Core :: Graphics, defect)
Core
Graphics
Tracking
()
RESOLVED
FIXED
People
(Reporter: roc, Assigned: roc)
References
Details
Attachments
(2 files)
(deleted),
patch
|
bas.schouten
:
review+
vlad
:
superreview+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
bas.schouten
:
review+
|
Details | Diff | Splinter Review |
Patches coming...
Assignee | ||
Comment 1•15 years ago
|
||
Also fixes a few trivial build warnings in the GL backend.
Right now the retained layer code only stores rects in the visible region, but if I want to change that later I'll need to be able to round-trip the regions that I store.
Attachment #447342 -
Flags: superreview?(vladimir)
Attachment #447342 -
Flags: review?(bas.schouten)
Assignee | ||
Comment 2•15 years ago
|
||
Simplifies BasicContainerLayer::~BasicContainerLayer and ContainerLayerD3D9::~ContainerLayerD3D9 by having them call RemoveLayer.
Also ContainerLayerD3D9::RemoveChild needs to null out the parent/prev-sibling/next-sibling links in all cases. Retained layers depends on us being able to remove a layer and re-add it elsewhere in the layer tree without anything getting confused. It might work with dangling pointers in those fields, but they are confusing.
ContainerLayerOGL needs to be fixed too, but that's harder since it still has the problem of LayerOGL::mNextSibling shadowing Layer::mNextSibling. So I haven't touched it here, I'm hoping someone else will fix that :-).
Attachment #447343 -
Flags: review?
Assignee | ||
Updated•15 years ago
|
Attachment #447343 -
Flags: review? → review?(bas.schouten)
Updated•15 years ago
|
Attachment #447343 -
Flags: review?(bas.schouten) → review+
Updated•15 years ago
|
Attachment #447342 -
Flags: review?(bas.schouten) → review+
Comment 3•15 years ago
|
||
Comment on attachment 447342 [details] [diff] [review]
Part 1: add user-data API and GetRoot to LayerManager, add mVisibleRegion to Layer
Good stuff!
Attachment #447342 -
Flags: superreview?(vladimir) → superreview+
Assignee | ||
Updated•15 years ago
|
Whiteboard: [needs landing]
Assignee | ||
Comment 4•14 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/5134171b7a01
http://hg.mozilla.org/mozilla-central/rev/dd0f1f0a96b3
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Whiteboard: [needs landing]
You need to log in
before you can comment on or make changes to this bug.
Description
•