Benjamin Stover (:stechz) Reporter
	Description • 14 years ago

Since docshell will no longer be requiring the use of GH3, and it was included for places use, we can get rid of the interface now.

	Doug Turner (:dougt)
	Comment 1 • 14 years ago

Reset Assignee to default.

	Matheus Kerschbaum Assignee
	Comment 3 • 13 years ago

Updated to tip.

	Marco Bonardo [:mak]
	Comment 4 • 13 years ago

Will check this soon, as a first feedback I think we should wait to land this after next merge, since it's pretty near.

	Marco Bonardo [:mak]
	Comment 5 • 13 years ago

Stupid question, but due to the nature of the patch I have to ask it: do the 2 tests you are modifying still pass correctly? test_history_redirects.js may probably work, I'm surprised of test_bug_411966.html. maybe it's already going through the new code, or was just plain wrong.

	Matheus Kerschbaum Assignee
	Comment 6 • 13 years ago

(In reply to comment #5)
> Stupid question, but due to the nature of the patch I have to ask it: do the
> 2 tests you are modifying still pass correctly? test_history_redirects.js
> may probably work, I'm surprised of test_bug_411966.html. maybe it's already
> going through the new code, or was just plain wrong.

I don't know if the tests are wrong but they do pass: http://tbpl.mozilla.org/?tree=Try&rev=e6ea48e2cb2b

	Marco Bonardo [:mak]
	Comment 7 • 13 years ago

Comment on attachment 549678 [details] [diff] [review]
patch

Review of attachment 549678 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with the following comment addressed.
I suppose you also need a superreview since you are removing an interface.

For added safety, please land this after we have merged for Firefox 9.

::: toolkit/components/places/nsNavHistory.cpp
@@ +2736,5 @@
>    // Normally docshell sends the link visited observer notification for us (this
>    // will tell all the documents to update their visited link coloring).
> +  // However, for downloads (since we implement nsIDownloadHistory)
> +  // this will not happen and we need to send it ourselves.
> +  if (newItem && aTransitionType == TRANSITION_DOWNLOAD) {

changing the comment to remove the reference to nsIGlobalHistory is fine, but you should not remove the aIsRedirect check from here, since addVisit is still an exposed API (even if we should try to deprecate it soonish). Also addURI may call into this.

	Matheus Kerschbaum Assignee
	Comment 8 • 13 years ago

Review comment addressed.

	Boris Zbarsky [:bzbarsky]
	Comment 9 • 13 years ago

Comment on attachment 551222 [details] [diff] [review]
patch

sr=me

	Matheus Kerschbaum Assignee
	Comment 10 • 13 years ago

Updated to tip.

	Marco Bonardo [:mak]
	Comment 11 • 13 years ago

http://hg.mozilla.org/integration/mozilla-inbound/rev/0f8e88bb5bc8

	Marco Bonardo [:mak]
	Comment 12 • 13 years ago

http://hg.mozilla.org/mozilla-central/rev/0f8e88bb5bc8

	Eric Shepherd [:sheppy]
	Comment 13 • 13 years ago

This was already updated:

https://developer.mozilla.org/en/NsIGlobalHistory3

Removal mentioned on Firefox 9 for developers.