Closed
Bug 569145
Opened 14 years ago
Closed 14 years ago
bustage on FreeBSD (in js/src/jsnativestack.cpp)
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
VERIFIED
FIXED
People
(Reporter: mpk, Assigned: mpk)
References
Details
(Whiteboard: fixed-in-tracemonkey)
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
igor
:
review+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #567937 +++
On FreeBSD builds have been broken in js/src/jsnativestack.cpp since the fix
for bug 237006 landed.
Part of the problem is that the necessary definitions/declarations are not
in pthread.h but in pthread_np.h (non-portable) instead. FreeBSD also defines
_PTHREAD_NP_H_ (in /usr/include/pthread_np.h) instead of PTHREAD_NP_H. These
entries seem to be part of the base system since 4.8-RELEASE (according to the
online manpages at http://www.freebsd.org/cgi/man.cgi).
Using the attached patch I was able to build without any problems.
Assignee | ||
Updated•14 years ago
|
No longer blocks: tracking_win64
No longer depends on: 567937
Assignee | ||
Updated•14 years ago
|
Attachment #448283 -
Attachment is patch: true
Attachment #448283 -
Attachment mime type: application/octet-stream → text/plain
Comment 1•14 years ago
|
||
Comment on attachment 448283 [details] [diff] [review]
unbreak FreeBSD builds in jsnativestack.cpp (mozilla-central)
>diff --git a/js/src/jsnativestack.cpp b/js/src/jsnativestack.cpp
>--- a/js/src/jsnativestack.cpp
>+++ b/js/src/jsnativestack.cpp
>@@ -46,16 +46,20 @@
> #elif defined(XP_MACOSX) || defined(DARWIN) || defined(XP_UNIX)
> # include <pthread.h>
>
> #else
> # error "Unsupported platform"
>
> #endif
>
>+#if defined(__FreeBSD__)
>+# include <pthread_np.h>
>+#endif
>+
Nit: move this ifdef into the above elif defined(XP_MACOSX) part right after include <pthread.h>.
Marco, can you land this at hg.mozilla.org/tracemonkey ?
Attachment #448283 -
Flags: review+
Assignee | ||
Comment 2•14 years ago
|
||
Igor, unfortunately I don't have write access.
Assignee: general → bugmail
Attachment #448283 -
Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #448290 -
Flags: review?
Assignee | ||
Comment 3•14 years ago
|
||
Comment on attachment 448290 [details] [diff] [review]
patch v2 (mozilla-central or tracemonkey)
Ooops, I just discovered that the tracemonkey version of the file differs
slightly from the one in mozilla central. If you want I can generate a
corrected patch for tracemonkey.
Attachment #448290 -
Flags: review?
Updated•14 years ago
|
Attachment #448290 -
Flags: review+
Comment 4•14 years ago
|
||
Whiteboard: fixed-in-tracemonkey
Comment 5•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•14 years ago
|
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•