Closed
Bug 569509
Opened 14 years ago
Closed 14 years ago
TinderboxPushlog Robot has stopped working because of UTF-8 nbsp char in the json which can't be handled by the server
Categories
(Tree Management Graveyard :: TBPL, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
References
Details
(Keywords: regression)
Attachments
(1 file)
(deleted),
patch
|
mstange
:
review+
|
Details | Diff | Splinter Review |
The simplest workaround here is to replace UTF-8 nbsp chars in the input stream with normal spaces before JSON encoding, as this patch does.
Markus, it would be great if you can land and deploy this patch, so that tbplbot returns asap. Thanks!
Attachment #448664 -
Flags: review?(mstange)
Comment 1•14 years ago
|
||
I haven't understood this patch yet, but I pushed and deployed anyway,
http://hg.mozilla.org/users/mstange_themasta.com/tinderboxpushlog/rev/8072a93dd06f
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 2•14 years ago
|
||
Thanks!
The UTF-8 nbsp sequence (0xc2a0) is converted into \u00a0 in the json string, and apparently the json parser that the bugzilla API uses can't handle that, so we'll get an error from the bugzilla API server. This didn't use to be an issue when we used GET because that character was escaped to 0xa0 when being passed as the URI.
Blocks: 569146
Keywords: regression
Comment 3•14 years ago
|
||
Where do these nbsp chars enter our world? Where do they come from?
Assignee | ||
Comment 4•14 years ago
|
||
(In reply to comment #3)
> Where do these nbsp chars enter our world? Where do they come from?
The Tinderbox log summary, between the date and the time. (At least that's one place they exist, not sure if those are the only one.)
Comment 5•14 years ago
|
||
Comment on attachment 448664 [details] [diff] [review]
Patch (v1)
Ah ok, cool, thanks.
Attachment #448664 -
Flags: review?(mstange) → review+
Updated•10 years ago
|
Product: Webtools → Tree Management
Updated•10 years ago
|
Product: Tree Management → Tree Management Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•