Open
Bug 570614
Opened 14 years ago
Updated 2 years ago
imgRequestProxy should not hold on to its listener - let imgRequestStatusTracker do it instead
Categories
(Core :: Graphics: ImageLib, defect)
Tracking
()
NEW
People
(Reporter: joe, Unassigned)
References
Details
Attachments
(1 file)
(deleted),
patch
|
Details | Diff | Splinter Review |
Right now we have no required users of imgRequestProxy::GetDecoderObserver - that is, the only user doesn't actually need it. We should put all the observer wrangling into imgRequestStatusTracker, and remove observers from imgRequestProxy altogether.
Unfortunately, we do need some way of associating listener with proxy - when the listener cancels the proxy, we'll need to remove the listener from the imgRequestStatusTracker. One option would be to unregister the listener explicitly - request->UnregisterListener(this) - before Cancel, but unfortunately we need to cancel asynchronously.
Reporter | ||
Updated•14 years ago
|
Whiteboard: [sg:nse]
Comment 1•14 years ago
|
||
So what's the new ownership model for imgRequestProxies and their observers?
Comment 2•14 years ago
|
||
I believe the goal would be for the StatusTracker to hold a weak reference to the observer. The user of the imgRequestProxy would need to unregister the observer before deleting the imgRequestProxy.
Comment 3•14 years ago
|
||
OK, so pretty much what we have now, sounds like...
Reporter | ||
Updated•14 years ago
|
Updated•2 years ago
|
Severity: normal → S3
You need to log in
before you can comment on or make changes to this bug.
Description
•