Ginn Chen Assignee
	Description • 14 years ago

I think 64bit enum is not a C/C++ standard.
We'd better use macro or const.

	Boris Zbarsky [:bzbarsky]
	Comment 2 • 14 years ago

The whole point here is to add more bits to this enum, ending up with lots of 64-bit values.  So if we can't do that we need to stop using an enum altogether, which is unfortunate.

	David Baron :dbaron:
	Comment 3 • 14 years ago

Comment on attachment 450345 [details] [diff] [review]
patch

What's the actual error message?

The other point here is that all of these constants need to be 64-bit.  Moving one of them out of the enum doesn't seem likely to change all the rest.

	Ginn Chen Assignee
	Comment 4 • 14 years ago

"../../dist/include/nsIFrame.h", line 272: Error: enum is not within the range of a long or unsigned long.

So at least we need to move out values above 0xffffffff, or to be consistent do not use enum for all the values.

	David Baron :dbaron:
	Comment 5 • 14 years ago

This should switch to #define for all the values.

	David Baron :dbaron:
	Comment 6 • 14 years ago

Any chance you could post a revised patch?

	David Baron :dbaron:
	Comment 8 • 14 years ago

Comment on attachment 454023 [details] [diff] [review]
patch

r=dbaron

	Ginn Chen Assignee
	Comment 9 • 14 years ago

http://hg.mozilla.org/mozilla-central/rev/02d5f18da8b7