Closed
Bug 571695
Opened 14 years ago
Closed 14 years ago
android build broken on Mac OS X host
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
DUPLICATE
of bug 598261
People
(Reporter: me, Assigned: me)
References
Details
(Keywords: mobile)
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
ted
:
review+
beltzner
:
approval2.0-
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.2.4) Gecko/20100527 Firefox/3.6.4 GTB7.1
Build Identifier:
There are two issues with js/src's autoconf script in m-c repo. patch is here. However the first fix to exclude objc lib is ugly and I'm not sure how to deal that better, currently.
Reproducible: Always
patch against m-c with http://hg.mozilla.org/users/mwu_mozilla.com/test-repo/ patches.
Attachment #450865 -
Flags: review?(mwu)
Comment 2•14 years ago
|
||
Comment on attachment 450865 [details] [diff] [review]
patch
So, the right fix for the LDFLAGS issue is most likely to make a HOST_LDFLAGS so we can prevent host and target LDFLAGS from mixing and messing each other up. The top level configure.in file has it.. not sure why js/src/configure.in doesn't.
Adding RANLIB to the exports looks right.
Attachment #450865 -
Flags: review?(mwu)
Updated•14 years ago
|
Status: UNCONFIRMED → NEW
Ever confirmed: true
Updated. However not sure if this will break other platform.
Attachment #450865 -
Attachment is obsolete: true
Comment 4•14 years ago
|
||
There's a number of other things that need to be updated to do HOST_LDFLAGS properly. I'll take a look at it. Removing dep on bug 552567 since this won't block our standard builds on Linux.
Assignee: nobody → mwu
No longer blocks: android
Updated•14 years ago
|
Attachment #450913 -
Flags: review?(ted.mielczarek)
Comment 6•14 years ago
|
||
Comment on attachment 450913 [details] [diff] [review]
patch update
Hm, on second thought this may be enough. Looks like it passes the tryserver.
Updated•14 years ago
|
Attachment #450913 -
Flags: review?(ted.mielczarek) → review+
Comment 8•14 years ago
|
||
is this ready land?
Updated•14 years ago
|
Attachment #450913 -
Flags: approval2.0?
Does this really need explicit approval to land? It is a bustage fix after all.
Updated•14 years ago
|
Attachment #450913 -
Flags: approval2.0? → approval2.0+
Comment 12•14 years ago
|
||
Comment on attachment 450913 [details] [diff] [review]
patch update
Removing approval; this has languished so long that I'm no longer sure if this patch is needed or still applies. Renominate with risk v. reward if you'd like.
Attachment #450913 -
Flags: approval2.0+ → approval2.0-
Comment 13•14 years ago
|
||
This ended up getting fixed in bug 598261
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → DUPLICATE
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•