Closed Bug 572077 Opened 15 years ago Closed 14 years ago

TM: Enabling the request model asserts in optimized builds,

Categories

(Core :: JavaScript Engine, defect)

defect
Not set
normal

Tracking

()

RESOLVED WONTFIX
Tracking Status
blocking2.0 --- beta3+

People

(Reporter: igor, Unassigned)

References

Details

The conservative native stack GC scanner from the bug 516832 assumes that the request model is followed to the letter and enforces that with extra asserts. But those are only enabled in the debug builds and, for example, would not present in nighties. Thus the idea is to activate the corresponding asserts in optimized builds for some time to get more test coverage. It should not negatively affect the performance as the asserts are not on the fast paths.
blocking2.0: beta1+ → beta2+
blocking2.0: beta2+ → beta3+
Is this going to make beta3?
(In reply to comment #1) > Is this going to make beta3? No: It turned out the are better ways to check for conservative GC assumptions, see, for example, bug 581919 and bug 580578. So I would like to see those in beta3.
So should this be RESO WONTFIX? I adjusted the flags on those other two bugs.
(In reply to comment #3) > So should this be RESO WONTFIX? I adjusted the flags on those other two bugs. This is indeed WONTFIX. I have found that the corresponding asserts in optimized would not provide better coverage. It is vastly better to simply add more asserts.
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.