Closed Bug 57226 Opened 24 years ago Closed 22 years ago

[FIX][RR]Changing attributes does not reframe :before/:after generated content [GC]

Categories

(Core :: CSS Parsing and Computation, defect, P1)

Product:
Core
Component:
CSS Parsing and Computation
Platform:
x86
Windows 2000
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla1.1beta

People

(Reporter: ian, Assigned: bzbarsky)

References

(
URL
)

Details

(Keywords: css2, testcase, Whiteboard: [Hixie-P3])

Attachments

(4 files)

Simple and self explanatory testcase. Output should say "Result: PASSED".
(deleted), text/html
Details
testcase with workaround
(deleted), text/html
Details
This testcase is basically the same bug.
(deleted), text/html
Details
Proposed fix
(deleted), patch
dbaron
: review+
kinmoz
: superreview+
Details | Diff | Splinter Review
STEPS TO REPRODUCE Change the content of an element's attribute, thus causing style contexts to be reresolved and thus causing :before or :after 'content' to change. ACTUAL RESULTS The contents don't change. EXPECTED RESULTS Well duh. See attachement for a simple case. During loading, the attribute of one of the elements is changed. If the test passes, the generated content should be changed from 'FAILED' to 'PASSED'.
URL: http://bugzilla.mozilla.org/showattac...
Keywords: correctness, css2, testcase
QA Contact: chrisd → py8ieh=bugzilla
Interesting problem with an interesting workaround: if you attempt to change the after-content, it doesn't work. However, you can remove the after-content (with a before-content for instance) and once it is removed, you can add the after- content you wanted. A bit confusing eh? Look at the attached testcase and it will be all clear.
Status: NEW → ASSIGNED
Target Milestone: --- → Future
Attached file testcase with workaround (deleted) —
I forgot to add that: - the style is indeed re-resolved, it even applies to the after-content, the only problem is that the after-content itself doesn't change. - the after-content doesn't appear in when dumping the content in Viewer.
See also http://www.hixie.ch/tests/adhoc/dom/css/rematching/004.xml
Summary: Changing attributes does not reframe :before/:after generated content → Changing attributes does not reframe :before/:after generated content [GC]
Whiteboard: [Hixie-P3]
Summary: Changing attributes does not reframe :before/:after generated content [GC] → [RR]Changing attributes does not reframe :before/:after generated content [GC]
for me :before got added http://mozilla.linuxfaqs.de/ ..set style to "false frame" - the the red ">" before the links IS a :before, and gets added. The external links should get an :after{content:" (extern)";}, but THAT doesn't work
What I'm seeing is bug 126072, :before and :after psuedo classes are not rendered when using alternate style sheets.
I'm going to mark this bug as *depending on* bug 126072 because this bug may also have issues with AttributeAffectsStyle (and I've been wondering whether AttributeAffectsStyle should have worked a little more like HasStateDependentStyle...).
Depends on: 126072
Assigning pierre's remaining Style System-related bugs to myself.
Assignee: pierre → dbaron
Status: ASSIGNED → NEW
Attached patch Proposed fix (deleted) — — Splinter Review
Since the generated content is generated during frame construction, any change to generated content requires creating the new frames....
Comment on attachment 88554 [details] [diff] [review] Proposed fix r=dbaron. Seems like the right fix. Perhaps the "XXX" could go?
Attachment #88554 - Flags: review+
Yeah, true. I'll remove the XXX before checking in.
Assignee: dbaron → bzbarsky
Priority: P3 → P1
Target Milestone: Future → mozilla1.1beta
Summary: [RR]Changing attributes does not reframe :before/:after generated content [GC] → [FIX][RR]Changing attributes does not reframe :before/:after generated content [GC]
Comment on attachment 88554 [details] [diff] [review] Proposed fix sr=kin@netscape.com
Attachment #88554 - Flags: superreview+
fixed on trunk
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
all testcases working as desired .. tested on win2k and linux 7.2 -- 2002-11-05trunk builds
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: