Closed
Bug 572288
Opened 14 years ago
Closed 14 years ago
Leak in gfxASurface::CreateSimilarSurface
Categories
(Core :: Graphics, defect)
Core
Graphics
Tracking
()
RESOLVED
FIXED
People
(Reporter: roc, Assigned: roc)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
jrmuizel
:
review+
|
Details | Diff | Splinter Review |
Oops, my bad. We need to release the cairo surface, because Wrap() effectively takes a reference.
I'm also adding MOZ_COUNT_CTOR/DTOR to gfxASurface so we can catch surface leaks. This caught bug 572287 so that fix needs to land before this one.
Attachment #451473 -
Flags: review?(jmuizelaar)
|
||
Comment 1•14 years ago
|
||
Comment on attachment 451473 [details] [diff] [review]
fix
I wouldn't complain if you added a comment to Wrap saying that it takes/adds a reference to the cairo_surface_t
Attachment #451473 -
Flags: review?(jmuizelaar) → review+
|
Assignee | |
Updated•14 years ago
|
Whiteboard: [needs landing]
|
|
Assignee | |
Comment 2•14 years ago
|
||
Status: NEW → ASSIGNED
Whiteboard: [needs landing]
|
|
Assignee | |
Updated•14 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•