Closed
Bug 573066
Opened 15 years ago
Closed 14 years ago
Fix ctypes stdcall closure tests
Categories
(Core :: js-ctypes, defect)
Tracking
()
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| blocking2.0 | --- | betaN+ |
People
(Reporter: dwitte, Assigned: dwitte)
Details
(Whiteboard: fixed-in-tracemonkey)
Attachments
(2 files)
|
(deleted),
patch
|
benjamin
:
review+
|
Details | Diff | Splinter Review |
|
(deleted),
patch
|
benjamin
:
review+
|
Details | Diff | Splinter Review |
The stdcall closure tests aren't that happy on Windows due to a libffi bug or two. I have some patches which I need to tidy up and push upstream; after which we can pull the new libffi rev and re-enable the tests.
|
Assignee | |
Comment 1•14 years ago
|
||
This is the libffi fix: adds X86_ANY to indicate any x86 platform, and then makes the stack calculation code not count space for the return value twice. Pushing upstream...
|
|
Assignee | |
Comment 2•14 years ago
|
||
Pretty self-explanatory. ;)
Attachment #462958 -
Flags: review?(benjamin)
|
|
Assignee | |
Comment 3•14 years ago
|
||
Comment on attachment 462957 [details] [diff] [review]
add X86_ANY
Looking for rs= here. (Though if it doesn't get upstreamed soon, we'll carry it
locally.)
Attachment #462957 -
Flags: review?(benjamin)
|
||
Updated•14 years ago
|
Attachment #462957 -
Flags: review?(benjamin) → review+
|
|
||
Updated•14 years ago
|
Attachment #462958 -
Flags: review?(benjamin) → review+
|
|
Assignee | |
Comment 4•14 years ago
|
||
This should block; the patch has been taken upstream so I just need to pull in libffi git head and enable the test.
blocking2.0: --- → ?
|
|
||
Updated•14 years ago
|
blocking2.0: ? → betaN+
|
|
Assignee | |
Comment 5•14 years ago
|
||
http://hg.mozilla.org/tracemonkey/rev/af3cf4beaa0a
... aaand we're all done fixing stdcall!
Whiteboard: fixed-in-tracemonkey
|
||
Comment 6•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•