Closed
Bug 573087
Opened 14 years ago
Closed 14 years ago
Automangle ctypes stdcall symbols
Categories
(Core :: js-ctypes, defect)
Tracking
()
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| blocking2.0 | --- | beta4+ |
People
(Reporter: dwitte, Assigned: dwitte)
References
Details
(Whiteboard: fixed-in-tracemonkey)
Attachments
(1 file)
|
(deleted),
patch
|
benjamin
:
review+
|
Details | Diff | Splinter Review |
On Windows, the symbol names for stdcall functions end up looking like:
_myfun@40
Where '40' is the (padded) net size of the arguments.
We should automangle this so that, instead of figuring out that nonsense, the user can just declare it as "myfun".
|
Assignee | |
Comment 1•14 years ago
|
||
This should block Fx4 since it's a significant API change.
blocking2.0: --- → ?
|
|
Assignee | |
Comment 2•14 years ago
|
||
Pretty self-explanatory. This passes tests on WIN32 for me... which is the strongest indicator that the argsize logic is correct. (The various C test functions exercise the combinations pretty well!)
|
||
Updated•14 years ago
|
Attachment #459617 -
Flags: review?(benjamin) → review+
|
|
||
Updated•14 years ago
|
blocking2.0: ? → beta4+
|
|
Assignee | |
Comment 3•14 years ago
|
||
Whiteboard: fixed-in-tracemonkey
|
||
Comment 4•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•