Closed
Bug 573149
Opened 15 years ago
Closed 14 years ago
Expose whether an addon requires a restart to enable/disable/uninstall/update
Categories
(Toolkit :: Add-ons Manager, defect)
Toolkit
Add-ons Manager
Tracking
()
VERIFIED
FIXED
mozilla2.0b3
Tracking | Status | |
---|---|---|
blocking2.0 | --- | beta3+ |
People
(Reporter: Unfocused, Assigned: asaf)
References
Details
(Keywords: APIchange, dev-doc-complete, Whiteboard: [AddonsRewrite])
Attachments
(1 file, 3 obsolete files)
(deleted),
patch
|
Details | Diff | Splinter Review |
Currently, there's no way to determine whether a restart is required to enable/disable/uninstall/update an addon (before we actually try any of these actions). We'd like to indicate this in the UI, so this blocks 573062.
Updated•15 years ago
|
Whiteboard: [rewrite] → [AddonsRewrite]
Version: unspecified → Trunk
Updated•15 years ago
|
blocking2.0: --- → beta2+
Whiteboard: [AddonsRewrite] → [AddonsRewrite][apichange]
Updated•14 years ago
|
Assignee: nobody → felipc
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•14 years ago
|
||
We decided not to handle upgrade at this point.
Attachment #454997 -
Flags: review?(dtownsend)
Comment 2•14 years ago
|
||
Comment on attachment 454997 [details] [diff] [review]
patch
This is great, but could you add some additional tests alongside your existing ones to make sure that when expectedRestart is false the appropriate flags aren't present?
Assignee | ||
Comment 3•14 years ago
|
||
Do you mind if I do that within that test (i.e. as else { ... } blocks)?
Comment 4•14 years ago
|
||
(In reply to comment #3)
> Do you mind if I do that within that test (i.e. as else { ... } blocks)?
No absolutely that is where I meant to put them.
Assignee | ||
Comment 5•14 years ago
|
||
Attachment #454997 -
Attachment is obsolete: true
Attachment #455288 -
Flags: review?(dtownsend)
Attachment #454997 -
Flags: review?(dtownsend)
Updated•14 years ago
|
Attachment #455288 -
Flags: review?(dtownsend) → review-
Comment 6•14 years ago
|
||
Comment on attachment 455288 [details] [diff] [review]
patch
This is unfortunately failing tests because it is also testing that the Addon objects for personas (from LightweightThemeManager) have the right values and there is no implementation for them. Right now because of the strange interactions between personas and themes they will sometimes require a restart to enable/disable. That oddity is going away soon though so I don't think it is worth doing the complex work to make that bit right. Instead I suggest removing the tests you have and instead adding some tests at appropriate points of test_bootstrap.js for the restartless cases and test_disable.js, test_uninstall.js and test_install.js for the other cases.
Assignee | ||
Comment 7•14 years ago
|
||
Also updates the mockprovider for the front-end bug.
Attachment #455288 -
Attachment is obsolete: true
Attachment #456096 -
Flags: review?(dtownsend)
Comment 8•14 years ago
|
||
Comment on attachment 456096 [details] [diff] [review]
patch
Looks good to me
Attachment #456096 -
Flags: review?(dtownsend) → review+
Comment 9•14 years ago
|
||
Can we get this checked in so it can make beta 2?
Comment 10•14 years ago
|
||
If this doesn't make the code freeze tonight, we'll go without it, so moving to beta3+
blocking2.0: beta2+ → beta3+
Assignee | ||
Comment 11•14 years ago
|
||
Attachment #456096 -
Attachment is obsolete: true
Comment 12•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Flags: in-testsuite+
Flags: in-litmus-
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b3
Comment 13•14 years ago
|
||
Verified on :
Mozilla/5.0 (Windows; Windows NT 6.0; rv:2.0b3) Gecko/20100805 Firefox/4.0b3
and
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b3) Gecko/20100805 Firefox/4.0b3
We can now see a tooltip ("restart required") which is the necessary solution for the blocking bug 5730762
Updated•14 years ago
|
Status: RESOLVED → VERIFIED
Updated•14 years ago
|
Keywords: dev-doc-complete
You need to log in
before you can comment on or make changes to this bug.
Description
•