Blair McBride [:Unfocused] (UNAVAILABLE) Reporter
	Description • 14 years ago

Currently, there's no way to determine whether a restart is required to enable/disable/uninstall/update an addon (before we actually try any of these actions). We'd like to indicate this in the UI, so this blocks 573062.

	Asaf Romano (gone) Assignee
	Comment 1 • 14 years ago

We decided not to handle upgrade at this point.

	Dave Townsend [:mossop]
	Comment 2 • 14 years ago

Comment on attachment 454997 [details] [diff] [review]
patch

This is great, but could you add some additional tests alongside your existing ones to make sure that when expectedRestart is false the appropriate flags aren't present?

	Asaf Romano (gone) Assignee
	Comment 3 • 14 years ago

Do you mind if I do that within that test (i.e. as else { ... } blocks)?

	Dave Townsend [:mossop]
	Comment 4 • 14 years ago

(In reply to comment #3)
> Do you mind if I do that within that test (i.e. as else { ... } blocks)?

No absolutely that is where I meant to put them.

	Dave Townsend [:mossop]
	Comment 6 • 14 years ago

Comment on attachment 455288 [details] [diff] [review]
patch

This is unfortunately failing tests because it is also testing that the Addon objects for personas (from LightweightThemeManager) have the right values and there is no implementation for them. Right now because of the strange interactions between personas and themes they will sometimes require a restart to enable/disable. That oddity is going away soon though so I don't think it is worth doing the complex work to make that bit right. Instead I suggest removing the tests you have and instead adding some tests at appropriate points of test_bootstrap.js for the restartless cases and test_disable.js, test_uninstall.js and test_install.js for the other cases.

	Asaf Romano (gone) Assignee
	Comment 7 • 14 years ago

Also updates the mockprovider for the front-end bug.

	Dave Townsend [:mossop]
	Comment 8 • 14 years ago

Comment on attachment 456096 [details] [diff] [review]
patch

Looks good to me

	Mike Beltzner [:beltzner, not reading bugmail]
	Comment 9 • 14 years ago

Can we get this checked in so it can make beta 2?

	Mike Beltzner [:beltzner, not reading bugmail]
	Comment 10 • 14 years ago

If this doesn't make the code freeze tonight, we'll go without it, so moving to beta3+

	Dave Townsend [:mossop]
	Comment 12 • 14 years ago

Landed: http://hg.mozilla.org/mozilla-central/rev/ab062b1c9bb2

	Ayan Shah[:ashah]
	Comment 13 • 14 years ago

Verified on :
Mozilla/5.0 (Windows; Windows NT 6.0; rv:2.0b3) Gecko/20100805 Firefox/4.0b3

and

Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b3) Gecko/20100805 Firefox/4.0b3

We can now see a tooltip ("restart required") which is the necessary solution for the blocking bug 5730762