Closed
Bug 573188
Opened 14 years ago
Closed 14 years ago
nsTextEditorState::SetValue leaks
Categories
(Core :: DOM: Editor, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: jruderman, Assigned: jruderman)
References
Details
(Keywords: memory-leak, regression, valgrind)
Attachments
(2 files)
|
(deleted),
patch
|
roc
:
review+
|
Details | Diff | Splinter Review |
|
(deleted),
text/plain
|
Details |
1765 nsString value(aValue);
1766 nsContentUtils::PlatformToDOMLineBreaks(value);
1767 *mValue = ToNewUTF8String(value);
I think this leaks the char* created by ToNewUTF8String, after making a copy of it.
I wrote a patch that makes the Valgrind warning go away, but I don't know what I'm doing here or how to test that the code still works, so please review carefully.
Attachment #452416 -
Flags: review?(roc)
|
Assignee | |
Comment 1•14 years ago
|
||
Attachment #452416 -
Flags: review?(roc) → review+
|
|
Assignee | |
Updated•14 years ago
|
Assignee: nobody → jruderman
|
|
Assignee | |
Comment 2•14 years ago
|
||
|
|
Assignee | |
Updated•14 years ago
|
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•