Closed Bug 573301 Opened 14 years ago Closed 14 years ago

Pushlog broken on non top-level repos (eg mozilla-1.9.2)

Categories

(mozilla.org Graveyard :: Server Operations, task)

task
Not set
critical

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: jhford, Assigned: aravind)

References

Details

Attachments

(1 file)

If you load http://hg.mozilla.org/mozilla-central/pushlog, the changeset links are in the format: http://hg.mozilla.org/mozilla-central/rev/1b20291d840e91447117160a9eeeb25b5300e011 where on http://hg.mozilla.org/releases/mozilla-1.9.2/pushlog they are showing up as: http://releases/mozilla-1.9.2/rev/843a6782d3f138ad0aa6150261b62e9d23b59d2e We have a function [1] that is requires the HG hostname to be in the comments field of a 'change' object. The source [2] of this comment field is the URL in the pushlog entry as far as I can tell. I remember something similar happening to HGWeb on friday during/after the HG maintenance so I am guessing that this is related. The specific issue was that HGweb links weren't having the first hg.mozilla.org subdirectory in them (i.e. linking to build/tools generated a link to hg.m.o/tools instead of hg.m.o/build/tools). If this is not the case, I guess this bug also belongs in the hg section of bugzilla. I am going to manually kick the missed build off and close the tree in the meantime. [1] isHgPollerTriggered - http://hg.mozilla.org/build/buildbotcustom/file/9fb8200c4cb7/misc.py#l98 [2] http://hg.mozilla.org/build/buildbotcustom/file/9fb8200c4cb7/changes/hgpoller.py#l380
Attachment #452515 - Flags: review?(nrthomas)
Comment on attachment 452515 [details] [diff] [review] match on repo_path instead of hgurl r+ as a bustage fix.
Attachment #452515 - Flags: review?(nrthomas) → review+
Summary: Pushlog broken on Mozilla-1.9.1, Mozilla-1.9.2 → Pushlog broken on non top-level repos (eg mozilla-1.9.2)
Blocks: 551015
I think I fixed pushlog links. in hgweb.config I originally had baseurl = /releases I changed that to baseurl = http://hg.mozilla.org/releases I don't think I should need to do that, setting baseurl = /releases seems to make everything else work just fine except for these pushlog links. All this has the unfortunate side-affect that you will get links to http://blah when you go https://blah/pushlog urls.
pushlog is looking better thanks. http://mercurial.selenic.com/bts/issue2221 may be relevant.
Issue is fixed. Please file a followup for comment #4.
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
On second thoughts, electrolysis is still broken: <link href="http:///projects/electrolysis/rev/f80302dc4c6cdc3ec12ca024388f3bc3a70f62cf"/> so we need to fix every repo or make a global fix.
Assignee: nobody → server-ops
Status: RESOLVED → REOPENED
Component: Release Engineering → Server Operations
QA Contact: release → mrz
Resolution: FIXED → ---
Assignee: server-ops → aravind
so I did fix it for every single repo, and http://hg.mozilla.org/projects/electrolysis/pushlog seems fine to me.
Bah, proxy/cache fail on my end. Sorry.
Status: REOPENED → RESOLVED
Closed: 14 years ago14 years ago
Resolution: --- → FIXED
Product: mozilla.org → mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: