Open Bug 573638 Opened 14 years ago Updated 2 years ago

Allow page-icon: protocol to pass-through to network when an icon is not in the database

Categories

(Toolkit :: Places, defect, P3)

defect
Points:
5

Tracking

()

People

(Reporter: mak, Unassigned)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [readinglist-v2])

using moz-anno:icon: is nice for treeviews but often implementers need just to get icon data from the database if it's present, from network if it's not present locally. We should provide this kind of pass-through protocol.
I *think* the moz-anno protocol handler can just create a HTTP channel and return that. So it shouldn't be too difficult in that respect. I'm hoping it'll be enough to just request /favicon.ico
Points: --- → 5
Flags: qe-verify-
Flags: firefox-backlog+
Blocks: 1132074
No longer blocks: 1132074
P2 for Reading List work, but worth considering if there's a simpler way to do this? EG kick off an explicit favicon fetch as items come into the RL so Places has it?
Whiteboard: [Reader:P2[
Whiteboard: [Reader:P2[ → [Reader:P2]
Priority: -- → P2
Whiteboard: [Reader:P2]
(In reply to Justin Dolske [:Dolske] from comment #3) > P2 for Reading List work, but worth considering if there's a simpler way to > do this? EG kick off an explicit favicon fetch as items come into the RL so > Places has it? That's possible, provided history is enabled. Unfortunately it wouldn't work for permanent pb, cause we only store favicons for pages that are in history or bookmarks.
Yea, I looked into alternatives recently (including adding it as a field that's synced). This still ended up looking like the easiest for now. Further into the future, I do wonder about maybe changing how the favicon service works a bit, to allow storing favicons for arbitrary pages (or rather, pages not in history/bookmarks). And allowing an external component like the ReadingList determine when a favicon should be evicted from the DB. Far from a trivial change though, I know.
(In reply to Blair McBride [:Unfocused] (I don't read bugmail - needinfo? me!) from comment #5) > Further into the future, I do wonder about maybe changing how the favicon > service works a bit, to allow storing favicons for arbitrary pages (or > rather, pages not in history/bookmarks). And allowing an external component > like the ReadingList determine when a favicon should be evicted from the DB. > Far from a trivial change though, I know. if we do that, and I'd be fine with the decision, we first need bug 977177. I don't want places.sqlite to become the favicons trashcan :)
Whiteboard: [readinglist-v2]
Moving to v2 -- we have the preview image, and that's sufficient to ship with for v1.
Priority: P2 → --
Priority: -- → P3
Summary: provide a moz-anno:icon: protocol with pass-through (if icon is not in database tries to fetch it from network) → Allow page-icon: protocol to pass-through to network when an icon is not in the database
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.