Closed Bug 573840 Opened 14 years ago Closed 14 years ago

Web Console styling is broken with a Persona

Categories

(DevTools :: General, defect)

Product:
DevTools
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(blocking2.0 betaN+)

Status:
VERIFIED FIXED
Tracking Flags:
Tracking Status
blocking2.0 --- betaN+

People

(Reporter: ddahl, Assigned: pcwalton)

References

Details

(Whiteboard: [kd4b6] [Web-Console-Testday])

Attachments

(3 files, 4 obsolete files)

Mac screenshot as of Firefox 4 beta 3.
(deleted), image/png
Details
Post-patch Mac screenshot.
(deleted), image/png
Details
[checked-in] Proposed patch, version 5.
(deleted), patch
dao
: review+
Details | Diff | Splinter Review
:root:-moz-lwtheme-brighttext { text-shadow: 1px 1px 2px black; } in chrome://global/skin/global.css seems to add a text-shadow to log entries in the HeadsUpDisplay/web console Screenshot here: http://yfrog.com/0sdominspectoraddonsforfip This is with the Robot theme enabled, but seems to be code in fx css.
You need to stop the text-shadow inheritance, i.e. set text-shadow: none, on the element that has the white background.
Assignee: nobody → pwalton
Blocks: consoleui, 580502
blocking2.0: --- → ?
Component: Theme → Developer Tools
QA Contact: theme → developer.tools
Hardware: x86 → All
Summary: Theme font class affect entire chrome → Web Console styling is broken with a Persona
Broadening the scope of this bug to include all of the Web Console styling under a Persona.
Status: NEW → ASSIGNED
Attached image Mac screenshot as of Firefox 4 beta 3. (deleted) —
Screenshot attached (slightly out of date, since it's of beta 3).
Whiteboard: [kd4b6]
non-primary UI + non-default option (persona) means this doesn't block. would accept a well-tested patch.
blocking2.0: ? → -
Where's the Web Console code?
(In reply to comment #6) > Where's the Web Console code? The code is in toolkit/components/console/hudservice/. The themes are in toolkit/themes/*stripe/global/webConsole.css.
Severity: normal → blocker
Attached patch Proposed patch, part 1. (obsolete) (deleted) — — Splinter Review
Patch part 1 fixes the styling on the Mac.
Attached patch Proposed patch, part 1, version 2. (obsolete) (deleted) — — Splinter Review
New version of part 1 of the patch removes the shadow everywhere on the Mac, not just in the output node.
Attachment #472060 - Attachment is obsolete: true
Attachment #472062 - Flags: feedback?(ddahl)
Attached image Post-patch Mac screenshot. (deleted) —
Here's a screenshot of what the Console looks like on the Mac with this patch and a Persona applied.
Severity: blocker → normal
colorful.
Blocks: devtools4b7
Attachment #472062 - Flags: feedback?(ddahl) → feedback?(mihai.sucan)
Attachment #472062 - Flags: review?(sdwilsh)
Comment on attachment 472062 [details] [diff] [review] Proposed patch, part 1, version 2. > .hud-box { > border-bottom: 1px solid #aaa; >+ text-shadow: none !important; drop !important >-.hud-console-filter-toolbar { >+.hud-console-filter-toolbar, .hud-console-filter-toolbar:-moz-lwtheme { This looks unnecessary.
Comment on attachment 472062 [details] [diff] [review] Proposed patch, part 1, version 2. removing review request that I added earlier until Dao's comment is addressed and this has been updated for Windows and Linux.
Attachment #472062 - Flags: review?(sdwilsh)
Patrick: I can't comment on this since I don't own a Mac and I can't test the patch. When you have the changes ready for Linux as well, I can comment. Otherwise, I believe it is acceptable - by looking into the screenshots. I'd also agree with Dão - the !important priority should not be required.
Attached patch Proposed patch, version 3. (obsolete) (deleted) — — Splinter Review
Attachment #474110 - Flags: review?(dao)
Attachment #472062 - Attachment is obsolete: true
Attachment #472062 - Flags: feedback?(mihai.sucan)
New patch adds Windows and Linux support. Review requested.
Re-requesting blocking. johnath thinks this is likely a blocker because possibly ~25% of our users use Personas and they can render the console output unintelligible.
blocking2.0: - → ?
blocking2.0: ? → betaN+
Comment on attachment 474110 [details] [diff] [review] Proposed patch, version 3. >--- a/toolkit/themes/gnomestripe/global/webConsole.css >+++ b/toolkit/themes/gnomestripe/global/webConsole.css >+.hud-console-filter-toolbar:-moz-lwtheme { >+ border-top: @scopeBarSeparatorBorder@ !important; There's no scopeBarSeparatorBorder for gnomestrip. >--- a/toolkit/themes/winstripe/global/webConsole.css >+++ b/toolkit/themes/winstripe/global/webConsole.css > .hud-console-filter-toolbar { >+ color: -moz-dialogtext !important; > padding: 1px 0px; > -moz-box-align: center; > } This doesn't seem to be needed, at least on Windows. >+.hud-console-filter-toolbar:-moz-lwtheme { >+ border-top: @scopeBarSeparatorBorder@ !important; Winstripe doesn't have this either.
Attachment #474110 - Flags: review?(dao) → review-
Attached patch Proposed patch, version 4. (obsolete) (deleted) — — Splinter Review
New patch addresses review comments.
Attachment #474110 - Attachment is obsolete: true
Attachment #475715 - Flags: review?(dao)
Comment on attachment 475715 [details] [diff] [review] Proposed patch, version 4. >--- a/toolkit/themes/gnomestripe/global/webConsole.css >+++ b/toolkit/themes/gnomestripe/global/webConsole.css > .hud-console-filter-toolbar { >+ color: -moz-dialogtext !important; > padding: 1px 0px; > -moz-box-align: center; > } This is also not needed. >--- a/toolkit/themes/pinstripe/global/webConsole.css >+++ b/toolkit/themes/pinstripe/global/webConsole.css > .hud-console-filter-toolbar { > background: @scopeBarBackground@ !important; >- border-bottom: @scopeBarSeparatorBorder@; >+ border-bottom: @scopeBarSeparatorBorder@ !important; >+ color: -moz-dialogtext !important; > padding: 0px 1px; > -moz-appearance: none !important; > -moz-box-align: center; > } I suppose the color isn't needed here either.
Attachment #475715 - Flags: review?(dao) → review-
New patch addresses review comments. Re-review requested.
Attachment #475715 - Attachment is obsolete: true
Attachment #476094 - Flags: review?(dao)
Attachment #476094 - Flags: review?(dao) → review+
Keywords: checkin-needed
Comment on attachment 476094 [details] [diff] [review] [checked-in] Proposed patch, version 5. http://hg.mozilla.org/mozilla-central/rev/38c0f5de0401
Attachment #476094 - Attachment description: Proposed patch, version 5. → [checked-in] Proposed patch, version 5.
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Status: RESOLVED → VERIFIED
Whiteboard: [kd4b6] → [kd4b6] [Web-Console-Testday]
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: