Closed
Bug 574467
Opened 14 years ago
Closed 14 years ago
Remove nsAddonRepository.js on updates
Categories
(SeaMonkey :: Installer, defect)
SeaMonkey
Installer
Tracking
(Not tracked)
RESOLVED
FIXED
seamonkey2.1a2
People
(Reporter: kairo, Assigned: kairo)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
Callek
:
review+
|
Details | Diff | Splinter Review |
Bug 568728 converted nsAddonRepository.js to a module, I just realized in the 2.1a2 update verification logs that we don't remove it on updates yet, though we should.
|
Assignee | |
Comment 1•14 years ago
|
||
Just remove it! :)
Attachment #453861 -
Flags: review?(bugspam.Callek)
|
||
Comment 2•14 years ago
|
||
Comment on attachment 453861 [details] [diff] [review]
just remove it
>diff --git a/suite/browser/nsBrowserStatusHandler.js b/suite/browser/nsBrowserStatusHandler.js
Not sure what this hunk is doing I assume another patch
>--- a/suite/installer/package-manifest.in
Thanks I noticed this late late last night and was going to investigate today
Attachment #453861 -
Flags: review?(bugspam.Callek) → review+
|
|
Assignee | |
Comment 3•14 years ago
|
||
(In reply to comment #2)
> (From update of attachment 453861 [details] [diff] [review])
> >diff --git a/suite/browser/nsBrowserStatusHandler.js b/suite/browser/nsBrowserStatusHandler.js
>
> Not sure what this hunk is doing I assume another patch
Yes, sorry, somehow bug 570004 made it into this patch.
> >--- a/suite/installer/package-manifest.in
>
> Thanks I noticed this late late last night and was going to investigate today
Hah! Will land that in a moment :)
|
|
Assignee | |
Comment 4•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.1a3
|
|
Assignee | |
Comment 5•14 years ago
|
||
Landed http://hg.mozilla.org/comm-central/rev/e0c779269296 on 2.1a2 relbranch as a build2 ridealong, so already fixed there now.
Target Milestone: seamonkey2.1a3 → seamonkey2.1a2
|
||
Comment 6•14 years ago
|
||
Did you miss to add the removed-files.in part?
http://mxr.mozilla.org/comm-central/search?string=nsAddonRepository.js&case=1&find=%2Finstaller%2F
Flags: in-testsuite-
Version: unspecified → Trunk
|
|
||
Comment 7•13 years ago
|
||
(In reply to Serge Gautherie (:sgautherie) from comment #6)
> Did you miss to add the removed-files.in part?
Bug 633394 eventually did it...
You need to log in
before you can comment on or make changes to this bug.
Description
•