User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2.4) Gecko/20100611 Firefox/3.6.4 (.NET CLR 3.5.30729) Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2.4) Gecko/20100608 Lightning/1.0b2 Thunderbird/3.1 ThunderBrowse/3.2.8.1 When filtering messages using the quick search/quick filter input, the correct/usual result is to 1) Show the number of found results 2) Highlight the list of messages blue if results are found, red otherwise This works on 3.1 when searching in a distinct Inbox/folder. When searching across a unified folder, however, the total number of results is always reported in the UI as "No results" (with the attendant red highlighting) even if there are results found in one or more of the folders. Reproducible: Always Steps to Reproduce: 1. Set up a profile with multiple mail accounts. 2. Select a unified folder to view the messages across multiple accounts. 3. Use the "Filter these messages..." box to enter a filter criteria that should succeed. Actual Results: The messages are correctly filtered (i.e., the message list will show matching messages), but the total number of results will be incorrectly reported in the filter bar as "No results" and the list of messages will have the red highlighting characteristic of an unsuccessful search. Expected Results: The total number of results found across folders should be reported. If results are found in any folder, the result list should be highlighted blue.

Confirmed Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2.4) Gecko/20100608 Thunderbird/3.1, switching to Unified Folders and entering the same search term as in All Folders with Inbox produces same results but on red background and "No results" reported. Tested on IMAP folder without synchronization or indexing, no duplicate.

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2.12pre) Gecko/20101010 Lightning/1.0b2 Lanikai/3.1.6pre This also happens with one account and a saved search. Using Quick filter to further filter inside a saved search will result in the described (inconsistent) behaviour. Tested on IMAP, POP, online and offline (synced). Makes no difference.

looks like a dup of 581522

Confirmed on Mozilla/5.0 (X11; Linux i686; rv:2.0b9pre) Gecko/20101227 Thunderbird/3.3a2pre I reproduced the problem 2 ways: when doing a text search, and when using the quickfilter buttons (Unread, Starred, etc.)

Not only Unified Folders, but also saved search folders. That is all folders that viewType == nsMsgViewType.eShowVirtualFolderResults Just have quick view of the source code, seems we need to override the function GetNumMsgsInView for mailnews/base/src/nsMsgXFVirtualFolderDBView.cpp, the base class nsMsgSearchDBView's implementation is NS_IMETHODIMP nsMsgSearchDBView::GetNumMsgsInView(PRInt32 *aNumMsgs) { NS_ENSURE_ARG_POINTER(aNumMsgs); *aNumMsgs = m_hdrsTable.Count(); return NS_OK; } In nsMsgXFVirtualFolderDBView, m_hdrsTable is NOT used, so *aNumMsgs always be zero.

Opera how would you feel about doing a patch ? (we'll help and answer all your questions :) )

Let me first try to setup the development environment ;-)

Should I provide test case? (and I don't know how to do that) Should I also create patch for 3.1 branch?

(In reply to comment #8) > Let me first try to setup the development environment ;-) Thanks

thx, this patch looks like the right thing to do. But we do need to add this to the unit test for the view code - see mailnews/base/test/unit/test_nsMsgDBView.js - I think just verify that view.numMsgsInView == the number of messages we expect...

Comment on attachment 527229 [details] [diff] [review] patch against thunderbird 3.3a3 Thx again for the patch. Clearing review request pending change to unit test. https://developer.mozilla.org/en/Writing_xpcshell-based_unit_tests shows you how to run your changed test, but basically, you change the test, and then cd <objdir>/mailnews/base/test make cd ../.. make SOLO_TEST=test_nsMsgDBView.js -C base/test check-one

This patch fix the follow issues: 1. the 'search' view report 0 message found for view sort type is NOT threaded. 2. The 'unified' or 'saved search' view report 0 message found for view sort type is NOT threaded. 3. The 'unified' or 'saved search' view report incorrect TOTAL messages when grouped by sort and have dummy rows, it will count the dummy rows. The patch is assume that total messages found equals to the number of 'OnSearchHit' called. I don't know if this is OK: + if ( !searchSession ) + return NS_OK; // just ignore This is needed to prevent crash when running test case.

the modified test case

thx for the patch, this is what I landed in the following changeset: http://hg.mozilla.org/comm-central/rev/33488d593cbc

Sorry for the bug spam. Serge is suffering from brain fade again.

Comment on attachment 528870 [details] [diff] [review] cumulative -p1 diff for landing http://hg.mozilla.org/releases/comm-2.0/rev/6c0694985f97