Closed
Bug 575188
Opened 14 years ago
Closed 12 years ago
XPCOM stack walker on Windows should print library+offset
Categories
(Core :: XPCOM, defect)
Tracking
()
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| blocking2.0 | --- | - |
People
(Reporter: jruderman, Assigned: ted)
References
Details
Attachments
(2 files)
When a Windows build has insufficient symbols, the XPCOM stack walker should print library+offset rather than badsym+offset. Preferably in the same format that Mac and Linux use.
I'd accept both (e.g. library+offset + badsym+offset) if it's hard to detect whether the symbols available to the stack walker are "insufficient".
This would allow Windows Tinderbox tests to use fix_stack_using_bpsyms.py and get decent stack traces.
|
Reporter | |
Comment 1•14 years ago
|
||
|
|
Reporter | |
Comment 2•14 years ago
|
||
The Windows stack walker actually works really well on non-stripped builds. It's only stripped builds that would benefit from this change.
|
|
Reporter | |
Comment 3•14 years ago
|
||
Fixing this might be as simple as grabbing aDetails->loffset in NS_FormatCodeAddressDetails. But I get disoriented by all the ifdefs in nsStackWalk.cpp.
|
||
Comment 4•14 years ago
|
||
Fixing this would help debug assertions that are only seen on tinderbox. I've got a few right now that I can't reproduce locally, and are windows only :(
|
|
||
Comment 5•14 years ago
|
||
In fact, I'd say that it's preventing me from fixing bug 599969 (blocker).
blocking2.0: --- → ?
|
|
||
Comment 7•14 years ago
|
||
Don't need this for bug 612617 anymore.
No longer blocks: 612617
blocking2.0: beta9+ → ?
|
||
Updated•14 years ago
|
blocking2.0: ? → -
|
Assignee | |
Updated•13 years ago
|
|
|
Reporter | |
Comment 8•12 years ago
|
||
Fixed by Ted as part of his patch in bug 751673.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 9•12 years ago
|
||
I kinda forgot there was a bug on this.
Assignee: nobody → ted
Depends on: 751673
You need to log in
before you can comment on or make changes to this bug.
Description
•