Closed
Bug 575463
Opened 14 years ago
Closed 14 years ago
Rename AddonInstall.sourceURL to sourceURI and make it return an nsIURI rather than a string
Categories
(Toolkit :: Add-ons Manager, defect)
Toolkit
Add-ons Manager
Tracking
()
VERIFIED
FIXED
mozilla2.0b2
| Tracking | Status | |
|---|---|---|
| blocking2.0 | --- | beta2+ |
People
(Reporter: mossop, Assigned: mossop)
References
Details
(Whiteboard: [AddonsRewrite][apichange][schemachange])
Attachments
(1 file)
|
(deleted),
patch
|
robert.strong.bugs
:
review+
|
Details | Diff | Splinter Review |
Both for consistency with getResourceURI which we changed in bug 563262 and because nsIURIs are generally more useful we're going to change the return type of sourceURL to nsIURI and so change its name as well to let callers know that the type has changed. This also includes tests to verify Addon.sourceURI exists and works as expected.
|
Assignee | |
Comment 1•14 years ago
|
||
Does the global rename and updates tests and other callers.
Assignee: nobody → dtownsend
Status: NEW → ASSIGNED
Attachment #454712 -
Flags: review?(robert.bugzilla)
|
||
Updated•14 years ago
|
Attachment #454712 -
Flags: review?(robert.bugzilla) → review+
|
|
Assignee | |
Comment 2•14 years ago
|
||
Landed: http://hg.mozilla.org/mozilla-central/rev/d1be3b90c8d4
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3b2
|
||
Comment 4•14 years ago
|
||
Marking as verified fixed based on check-in and passing tests.
Status: RESOLVED → VERIFIED
Flags: in-testsuite+
Flags: in-litmus-
You need to log in
before you can comment on or make changes to this bug.
Description
•