Closed
Bug 575601
Opened 14 years ago
Closed 9 years ago
Remove whitespace around entities for tos/pp
Categories
(Firefox :: Sync, defect)
Firefox
Sync
Tracking
()
RESOLVED
WONTFIX
People
(Reporter: mconnor, Unassigned)
References
(Depends on 1 open bug, )
Details
(Keywords: polish)
Flagged by the Italian localizer.
http://www.pseudotecnico.org/mozilla/screenshot/sync3.png
Flags: blocking-fx-sync1.4+
Reporter | ||
Comment 1•14 years ago
|
||
We'll have to fix this in 1.5, so as to not break other locales.
Flags: blocking-fx-sync1.4+ → blocking-fx-sync1.4-
Target Milestone: --- → 1.5
Reporter | ||
Comment 2•14 years ago
|
||
I think this is fixed in the new wizard.
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Comment 3•14 years ago
|
||
Apparently not :( See bug 591122 comment 4. Sigh, I think fixing this would mean string changes... *big sigh*
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment 4•14 years ago
|
||
(In reply to comment #3)
> Apparently not :( See bug 591122 comment 4. Sigh, I think fixing this would
> mean string changes... *big sigh*
Why do you think we need new entities? Do you mean a new string with variables for URLs instead of multiple strings? For the little I can understand it's a problem with the XUL structure, so it should be possible to work around this :-\
Comment 5•14 years ago
|
||
(In reply to comment #4)
> (In reply to comment #3)
> > Apparently not :( See bug 591122 comment 4. Sigh, I think fixing this would
> > mean string changes... *big sigh*
>
> Why do you think we need new entities?
I first thought we would have to make the whitespace part of the entity. But that wouldn't be very clever because then it'd be part of the link in English -- very ugly. Instead I think we would need a *new* entity for the space which would be empty in the Italian locale.
Though I wonder -- and please forgive my ignorance -- why the article ("la", shortened to "l'") can't be part of the link? That would seem like the easiest solution to me, especially in the context of the string freeze. But I'm not the localizer, so please enlighten me. :)
Comment 6•14 years ago
|
||
(In reply to comment #5)
> Though I wonder -- and please forgive my ignorance -- why the article ("la",
> shortened to "l'") can't be part of the link? That would seem like the easiest
> solution to me, especially in the context of the string freeze. But I'm not the
> localizer, so please enlighten me. :)
It's just a matter of style, we usually don't include articles and punctuation in a link ;-)
BTW, is that a real space or just some padding? I think I tried to look at that window's code and I wasn't unable to find an hard-coded space.
Reporter | ||
Updated•14 years ago
|
Target Milestone: 1.5 → 1.6
Comment 7•14 years ago
|
||
(In reply to comment #6)
> (In reply to comment #5)
> > Though I wonder -- and please forgive my ignorance -- why the article ("la",
> > shortened to "l'") can't be part of the link? That would seem like the easiest
> > solution to me, especially in the context of the string freeze. But I'm not the
> > localizer, so please enlighten me. :)
>
> It's just a matter of style, we usually don't include articles and punctuation
> in a link ;-)
Well, with the easy setup UI we have started putting punctuation in links, so I think this point is void now.
I'm leaving this open for now, but in my (very uninformed) opinion, we might as well resolve this as WONTFIX.
Comment 8•14 years ago
|
||
(In reply to comment #7)
> I'm leaving this open for now, but in my (very uninformed) opinion, we might as
> well resolve this as WONTFIX.
I disagree ;-)
The problem here is not if we should include punctuation inside a link - which IMO it's not good but far from being an error - the problem is why the software add extra spaces between strings (and putting a space between a truncated definite article and the relative noun is a plain error).
Reporter | ||
Updated•14 years ago
|
Assignee: mconnor → nobody
Reporter | ||
Updated•13 years ago
|
Target Milestone: 1.6 → ---
Comment 9•12 years ago
|
||
FxA should have some bearing on this.
Comment 10•9 years ago
|
||
We don't use the Wizard and have a revamped TOS/PN. I doubt this bug is still relevant.
Status: NEW → RESOLVED
Closed: 14 years ago → 9 years ago
Resolution: --- → WONTFIX
Assignee | ||
Updated•6 years ago
|
Component: Firefox Sync: UI → Sync
Product: Cloud Services → Firefox
You need to log in
before you can comment on or make changes to this bug.
Description
•