Closed
Bug 575637
Opened 14 years ago
Closed 14 years ago
[e10s] Protect chromeRegistry chrome from ending up in the content process
Categories
(Core :: IPC, defect)
Core
IPC
Tracking
()
RESOLVED
WORKSFORME
| Tracking | Status | |
|---|---|---|
| fennec | - | --- |
People
(Reporter: dougt, Unassigned)
References
Details
>+++ b/chrome/src/nsChromeFactory.cpp
>+#ifdef MOZ_IPC
>+ if (XRE_GetProcessType() == GeckoProcessType_Content)
>+ chromeRegistry = new nsChromeRegistryContent;
>+#endif
>+ if (!chromeRegistry)
>+ chromeRegistry = new nsChromeRegistryChrome;
Might be a good idea to make sure we don't end up with an
nsChromeRegistryChrome in a content process by tossing an |else| in there?
|
||
Updated•14 years ago
|
tracking-fennec: --- → ?
|
||
Comment 2•14 years ago
|
||
This file doesn't seem to exist anymore ? nor does a search for "chromeRegistry = new nsChromeRegistryContent;" or "chromeRegistry = new nsChromeRegistryChrome;" give any hits in the current tree?
|
||
Comment 3•14 years ago
|
||
Seeing as nsChromeRegistry::GetSingleton() now contains the following code:
> nsRefPtr<nsChromeRegistry> cr;
>#ifdef MOZ_IPC
> if (GeckoProcessType_Content == XRE_GetProcessType())
> cr = new nsChromeRegistryContent();
> else
>#endif
> cr = new nsChromeRegistryChrome();
I guess we're done here.
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → WORKSFORME
You need to log in
before you can comment on or make changes to this bug.
Description
•