Closed
Bug 575648
Opened 14 years ago
Closed 14 years ago
[e10s] confusing use of AppUnitsToIntCSSPixels in DocumentRendererChild.cpp
Categories
(Core :: IPC, defect)
Core
IPC
Tracking
()
RESOLVED
WONTFIX
| Tracking | Status | |
|---|---|---|
| fennec | - | --- |
People
(Reporter: dougt, Unassigned)
References
Details
>+ _width = nsPresContext::AppUnitsToIntCSSPixels(w);
>+ _height = nsPresContext::AppUnitsToIntCSSPixels(h);
Really? If the args are app units, shouldn't they be nscoord instead of
PRInt32? This seems to apply throughout here.
Should there be sanity checks for negative w and h here?
|
||
Updated•14 years ago
|
tracking-fennec: --- → ?
|
Reporter | |
Comment 1•14 years ago
|
||
http://mxr.mozilla.org/mozilla-central/source/content/canvas/src/DocumentRendererChild.cpp#131
cjones, is negative w and h an issue?
Sorry, missed this comment yesterday. We'd probably hit a cairo assertion for negative w/h and get back an invalid cairo surface, but this is dead code walking so I'm not sure how much we care.
|
|
Reporter | |
Comment 3•14 years ago
|
||
chris, should we just wontfix
|
|
Reporter | |
Updated•14 years ago
|
tracking-fennec: ? → 2.0-
|
|
Reporter | |
Updated•14 years ago
|
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•