>+++ b/dom/ipc/ContentProcessProcess.h >+/** >+ * ContentProcessProcess is a singleton on the content process which represents >+ * the main thread where tab instances live. >+ */ Put this right after the license block so it shows up in mxr? >+++ b/dom/ipc/PContentDialog.ipdl >+ __delete__(PRInt32[] aIntParams, nsString[] aStringParams); You know, the fact that the delete lives on the protocol while the create lives on the manager is a bit of a pain in terms of figuring out what the protocol would do... Please document as a substitute? >+++ b/dom/ipc/PContentProcess.ipdl Please document what this protocol represents? And what the various messages mean? What do the rv values for all the pref stuff mean, for example? >+++ b/dom/ipc/PDocumentRenderer.ipdl Document. >+++ b/dom/ipc/PDocumentRendererNativeID.ipdl Document. >+++ b/dom/ipc/PDocumentRendererShmem.ipdl Document. >+++ b/dom/ipc/PIFrameEmbedding.ipdl Document.

probably we can doc these too: >+++ b/embedding/base/nsIDialogCreator.idl This needs documentation. >+++ b/js/ipc/PObjectWrapper.ipdl I'm not sure I understand the ownership model of PObjectWrapper. Worth documenting.

wont block fennec for this.

mostly a meta bug about all sorts of interfaces. Maybe cjones to take the first swing...

Why don't you ping the people who wrote this code and didn't document it?

sure. let me bounce it to bsmedberg since he was running the team.

(In reply to comment #0) > >+++ b/dom/ipc/PIFrameEmbedding.ipdl > > Document. Was this interface removed or merged somewhere else. In reading an old patch I see this file referenced.

It's PBrowser now. There's a nonnegligible chance it'll be renamed again to PTab.