Closed
Bug 575726
Opened 14 years ago
Closed 14 years ago
firefox menu sits two pixels too high on the window frame | aero glass
Categories
(Firefox :: Theme, defect)
Tracking
()
RESOLVED
FIXED
Firefox 4.0b2
People
(Reporter: asa, Assigned: dao)
References
Details
Attachments
(7 files)
The new Firefox menu sits one pixel too high in the toolbar giving it the appearance of wrapping over the top of the window.
I think that the button's top (and maybe the bottom?) should align with the window frame border at the same place as the windows min/restore/close control group.
Reporter | ||
Comment 1•14 years ago
|
||
actually, I think it's two pixels too high.
Reporter | ||
Updated•14 years ago
|
Summary: firefox menu sits one pixel too high on the window frame | aero glass → firefox menu sits two pixels too high on the window frame | aero glass
Updated•14 years ago
|
Blocks: FirefoxButton
Comment 2•14 years ago
|
||
This bug is duplicate of bug 574681.
Assignee | ||
Comment 3•14 years ago
|
||
(In reply to comment #2)
> This bug is duplicate of bug 574681.
No.
Comment 4•14 years ago
|
||
Assignee | ||
Comment 5•14 years ago
|
||
Bug 574681 mixes various things, whereas this one is very clear and well-scoped.
Comment 6•14 years ago
|
||
So what, we are going to fill seperate bugs for every small glitch we found?
Comment 7•14 years ago
|
||
Well, if that gets a specific bug fixed faster, then yeah.
Comment 8•14 years ago
|
||
You know what means "effective work"? It surely isn't asking reviews for three patches for three small glitches, instead of asking one review for one patch that will cover all three of 'em.
Assignee | ||
Comment 9•14 years ago
|
||
Please avoid making comments that don't help moving this bug along.
Assignee: nobody → dao
Status: NEW → ASSIGNED
Assignee | ||
Comment 10•14 years ago
|
||
Attachment #455096 -
Flags: review?(gavin.sharp)
Comment 11•14 years ago
|
||
I'm not seeing this on a nightly build w/a slightly different ui setup.
Comment 12•14 years ago
|
||
The window captions show they're light line below the black border. The menu button doesn't look the same. It looks like its hanging rather than inside the window border.
Updated•14 years ago
|
Attachment #455096 -
Flags: review?(gavin.sharp) → review+
Assignee | ||
Comment 13•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.7b2
Comment 14•14 years ago
|
||
=\ it still looks too high.
http://people.mozilla.com/~faaborg/files/20100625-tabsOnTop/mouseBounce.png
Comment 15•14 years ago
|
||
Target Mileston is Firefox 4.0b2, not 3.7b2.
Comment 16•14 years ago
|
||
I think it should only be 1 pixel lower instead of 2. Otherwise it leaves a white line (part of the Aero window border) on top of the minefield button and makes it look tacky, especially when you click on it. White doesn't contrast well as a border color with orange.
Comment 17•14 years ago
|
||
(In reply to comment #16)
> I think it should only be 1 pixel lower instead of 2. Otherwise it leaves a
> white line (part of the Aero window border) on top of the minefield button and
> makes it look tacky, especially when you click on it. White doesn't contrast
> well as a border color with orange.
I think the design in comment 14 makes the most sense, just keep it orange, but that's discussion for another bug.
Comment 18•14 years ago
|
||
(In reply to comment #17)
> (In reply to comment #16)
> I think the design in comment 14 makes the most sense, just keep it orange, but
> that's discussion for another bug.
I meant that there's a gap between the Firefox button and the window frame. The white aero window border is showing through when really the Firefox button should be on top of it. I'm fine with making the button larger, but the border should not be showing. It should look like the button is a puzzle piece that fits into a cut out piece of the window.
Comment 19•14 years ago
|
||
Now there's a white line above the firefox button, it should look like the caption button.
Comment 20•14 years ago
|
||
:D Instead of fixing it, we reversed it. Cool. ;)
Comment 21•14 years ago
|
||
The margin should be reduced to 1px (instead of 2) and the height should be increased by 1px.
Comment 22•14 years ago
|
||
(In reply to comment #21)
> The margin should be reduced to 1px (instead of 2) and the height should be
> increased by 1px.
Yes the top of the button should be inline with the white edge of the window not the dark border.
Comment 23•14 years ago
|
||
Er, didn't you meant direct oposite? Dark edge is outer one, not the white edge.
Comment 24•14 years ago
|
||
(In reply to comment #23)
> Er, didn't you meant direct oposite? Dark edge is outer one, not the white
> edge.
I don't think I did, but I might need more coffee :) The top of the button should line up with the white edge and not the dark border.
Or rather it should look like this attachment. So 1px down not 2px.
Comment 25•14 years ago
|
||
Ah yes, I din't notice that dark line on mokcup. My bad. :)
Comment 26•14 years ago
|
||
Compare the current one to the mockups. We seem to be missing a bit of detail.
Comment 27•14 years ago
|
||
(In reply to comment #26)
> Created an attachment (id=455503) [details]
> look at me!
>
> Compare the current one to the mockups. We seem to be missing a bit of detail.
That is probably a separate bug and if it isn't it will be.
Comment 28•14 years ago
|
||
You mean bug 574681?
Comment 29•14 years ago
|
||
I'm still seeing this problem in Firefox 4 beta 3.
1. Install Firefox 4 beta 3 with a new profile.
2. When Firefox launches after the install, notice that the Fx button is too high.
The problem disappears after closing the "make this your default browser" popup (see lower half of screenshot), or just by using the browser for awhile. It only occurs on a clean install of Firefox.
You need to log in
before you can comment on or make changes to this bug.
Description
•