WIP patch, not for review yet, just want to get some early feedback :) The patch moves HgData, TinderboxData and Data into DatasourceClassic that treats both datasources as one unit. It also refactors how the pushes list is generated, which means that it adds more pushes when the history button is pressed instead of replacing the whole list. TODO items: - implement error handling - make updates work, they currently dont - save the results in the datasource, currently only the results loaded last are kept alive, so refreshing the whole list when switching time zones only loads half the results - both items above depend on merging newly loaded results, so that the UI can be refreshed based on changed items The patch uses only tinderbox showbuilds.cgi which is slower than the current method, however it uses smaller deltas for history and updates once I implement them so the effects should be positive overall. This also means that loading tinderbox fails more frequently, which results in the whole page being unusable, as both datasources need to succeed in order for it to work.

I also plan to do 2/3 more patches: - support for multi-branch trees - unify details/summary loading, this may not work that well with the currently very slow tinderbox based summary parser. The plan would be to pre-parse the summaries on the server once we have a real server-based datasource. - implement “history as you scroll” and removing the loading indicators, again this makes absolutely no sense with the current datasource and is merely a preparation for when we have a fast non-failing server.

Comment on attachment 455665 [details] [diff] [review] WIP Part1: unify datasources Looks good to me

Just uploading my current work after the summit since I may not have the ability to work on it before I get home.

FWIW, the WIP patch looks good to me as well, but I'm not very familiar with all of the code which this patch is changing.

Just removes the two classes, to aid with future refactorings.

My patch writing skills have failed again, missed to write the right url in the commit message replace.

http://hg.mozilla.org/users/mstange_themasta.com/tinderboxpushlog/rev/7ac0e5b82192 Kill HgData and TinderboxData

LogID: http://hg.mozilla.org/users/mstange_themasta.com/tinderboxpushlog/rev/56c5ab8abb2b Loading: http://hg.mozilla.org/users/mstange_themasta.com/tinderboxpushlog/rev/6f99c89a3c29

show loading 0% when reloading and using history: http://hg.mozilla.org/users/mstange_themasta.com/tinderboxpushlog/rev/cfaf4671cf12

This is basically done now.