Closed
Bug 576692
Opened 14 years ago
Closed 9 years ago
Add documentation to PHttpChannel.ipdl
Categories
(Core :: Networking: HTTP, defect)
Tracking
()
RESOLVED
WONTFIX
People
(Reporter: jduell.mcbugs, Assigned: jduell.mcbugs)
References
Details
(Whiteboard: [necko-backlog])
Attachments
(1 file)
|
(deleted),
patch
|
bzbarsky
:
review+
joe
:
approval2.0-
|
Details | Diff | Splinter Review |
Add documentation to PHttpChannel.ipdl
Attachment #455813 -
Flags: review?(bzbarsky)
|
||
Updated•14 years ago
|
Attachment #455813 -
Attachment is patch: true
Attachment #455813 -
Attachment mime type: application/octet-stream → text/plain
|
||
Comment 1•14 years ago
|
||
>+ // Sets
> SetCacheTokenCachedCharset(nsCString charset);
This could be improved.
>+ // This method is currently needed only to free the cache descriptor, which
>+ // we keep around in case SetCacheTokenCachedCharset messages arrive late
>+ // (i.e. after the nsHttpChannel's OnStopRequest has completed).
> OnStopRequestCompleted();
This no longer exists.
OS: Linux → Windows Server 2003
|
|
||
Comment 2•14 years ago
|
||
BTW, shouldn't we use /** */ doxygen style for comments?
|
|
||
Comment 3•14 years ago
|
||
Comment on attachment 455813 [details] [diff] [review]
Add documentation to PHttpChannel.ipdl
>+ // - When this message is sent, we are guaranteed to send OnStart/OnStop
>+ // messages back to the child.
Shouldn't that comment start with "If this message is sent successfully"?
> + // Sets
Should there be more comment there?
r=me with those addressed.
Attachment #455813 -
Flags: review?(bzbarsky) → review+
|
|
||
Updated•14 years ago
|
Assignee: nobody → jduell.mcbugs
|
||
Updated•14 years ago
|
tracking-fennec: --- → ?
|
||
Comment 6•14 years ago
|
||
Comment on attachment 455813 [details] [diff] [review]
Add documentation to PHttpChannel.ipdl
doc only change. love docs.
Attachment #455813 -
Flags: approval2.0+
|
|
||
Updated•14 years ago
|
Keywords: checkin-needed
|
||
Comment 8•14 years ago
|
||
Comment on attachment 455813 [details] [diff] [review]
Add documentation to PHttpChannel.ipdl
not ready for checkin => not approved
Attachment #455813 -
Flags: approval2.0+ → approval2.0-
|
||
Comment 9•11 years ago
|
||
Mass tracking-e10s flag change. Filter bugmail on "2be0fcce-e36a-4e2c-aa80-0e3d33eb5406".
tracking-e10s:
--- → +
|
|
||
Updated•11 years ago
|
|
|
||
Updated•11 years ago
|
|
||
Comment 10•9 years ago
|
||
jason, please land this or wontfix it or something
Flags: needinfo?(jduell.mcbugs)
Whiteboard: [necko-backlog]
|
Assignee | |
Updated•9 years ago
|
Status: NEW → RESOLVED
Closed: 9 years ago
Flags: needinfo?(jduell.mcbugs)
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•