Closed
Bug 576831
Opened 14 years ago
Closed 14 years ago
Remove nsICSSStyleRule
Categories
(Core :: CSS Parsing and Computation, defect, P4)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla5
People
(Reporter: craig.topper, Assigned: craig.topper)
References
(Blocks 1 open bug)
Details
Attachments
(6 files, 20 obsolete files)
(deleted),
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
This interface is only implemented by one class so there is no reason for it to exist.
Assignee | ||
Comment 1•14 years ago
|
||
Attachment #455923 -
Flags: review?(dbaron)
Assignee | ||
Comment 2•14 years ago
|
||
Attachment #455924 -
Flags: review?(dbaron)
Assignee | ||
Comment 3•14 years ago
|
||
Attachment #455925 -
Flags: review?(dbaron)
Assignee | ||
Comment 4•14 years ago
|
||
Attachment #455926 -
Flags: review?(dbaron)
Assignee | ||
Comment 5•14 years ago
|
||
Attachment #455928 -
Flags: review?(dbaron)
Assignee | ||
Updated•14 years ago
|
Attachment #455928 -
Attachment is patch: true
Attachment #455928 -
Attachment mime type: application/octet-stream → text/plain
Assignee | ||
Comment 6•14 years ago
|
||
Attachment #455957 -
Flags: review?(dbaron)
Assignee | ||
Comment 7•14 years ago
|
||
Patches depend on patches in bug 575901 and bug 571946
Assignee | ||
Updated•14 years ago
|
Attachment #455923 -
Flags: review?(dbaron) → review?(bzbarsky)
Assignee | ||
Updated•14 years ago
|
Attachment #455924 -
Flags: review?(dbaron) → review?(bzbarsky)
Assignee | ||
Updated•14 years ago
|
Attachment #455925 -
Flags: review?(dbaron) → review?(bzbarsky)
Assignee | ||
Updated•14 years ago
|
Attachment #455926 -
Flags: review?(dbaron) → review?(bzbarsky)
Assignee | ||
Updated•14 years ago
|
Attachment #455928 -
Flags: review?(dbaron) → review?(bzbarsky)
Assignee | ||
Updated•14 years ago
|
Attachment #455957 -
Flags: review?(dbaron) → review?(bzbarsky)
Comment 8•14 years ago
|
||
Comment on attachment 455923 [details] [diff] [review]
Part 1: Rename CSSStyleRuleImpl
r=bzbarsky
Attachment #455923 -
Flags: review?(bzbarsky) → review+
Comment 9•14 years ago
|
||
Comment on attachment 455924 [details] [diff] [review]
Part 2: rename DOMCSSStyleRuleImpl
r=bzbarsky
Attachment #455924 -
Flags: review?(bzbarsky) → review+
Comment 10•14 years ago
|
||
Though it's worth double-checking with dbaron on these renames. Maybe we want to just drop both the "ns" prefix and the "Impl" suffix and stick these in mozilla::css?
Comment 11•14 years ago
|
||
Comment on attachment 455925 [details] [diff] [review]
Part 3: Rename CSSImportantRule
r=bzbarsky, with the caveat above.
Attachment #455925 -
Flags: review?(bzbarsky) → review+
Comment 12•14 years ago
|
||
Comment on attachment 455928 [details] [diff] [review]
Part 5: Remove virtual from methods that came from nsICSSStyleRule
r=bzbarsky
Attachment #455928 -
Flags: review?(bzbarsky) → review+
Comment 13•14 years ago
|
||
Comment on attachment 455957 [details] [diff] [review]
Part 6: DeCOMtaminate the methods that came from nsICSSStyleSheet
r=bzbarsky
Attachment #455957 -
Flags: review?(bzbarsky) → review+
Comment 14•14 years ago
|
||
(In reply to comment #10)
> Though it's worth double-checking with dbaron on these renames. Maybe we want
> to just drop both the "ns" prefix and the "Impl" suffix and stick these in
> mozilla::css?
We probably do, but I don't think it needs to happen here. This is an improvement over the current state.
Assignee | ||
Updated•14 years ago
|
Attachment #455926 -
Flags: review?(bzbarsky)
Assignee | ||
Comment 15•14 years ago
|
||
Old patch didn't apply anymore so I went ahead and added namespace.
Attachment #461798 -
Flags: review?(bzbarsky)
Assignee | ||
Updated•14 years ago
|
Attachment #455923 -
Attachment is obsolete: true
Assignee | ||
Updated•14 years ago
|
Attachment #461798 -
Attachment description: 455923: Part 1: Rename CSSStyleRuleImpl updated to use namespace → Part 1: Rename CSSStyleRuleImpl updated to use namespace
Assignee | ||
Comment 16•14 years ago
|
||
Attachment #455924 -
Attachment is obsolete: true
Attachment #461799 -
Flags: review?(bzbarsky)
Assignee | ||
Comment 17•14 years ago
|
||
Attachment #461799 -
Attachment is obsolete: true
Attachment #461800 -
Flags: review?(bzbarsky)
Attachment #461799 -
Flags: review?(bzbarsky)
Assignee | ||
Updated•14 years ago
|
Attachment #461800 -
Attachment description: 461799: Part 2: rename DOMCSSStyleRuleImpl updated to use namespace. → Part 2: rename DOMCSSStyleRuleImpl updated to use namespace.
Assignee | ||
Comment 18•14 years ago
|
||
Attachment #461801 -
Flags: review?(bzbarsky)
Assignee | ||
Updated•14 years ago
|
Attachment #455925 -
Attachment is obsolete: true
Assignee | ||
Updated•14 years ago
|
Attachment #461801 -
Attachment is obsolete: true
Attachment #461801 -
Flags: review?(bzbarsky)
Assignee | ||
Comment 19•14 years ago
|
||
Attachment #461803 -
Flags: review?(bzbarsky)
Assignee | ||
Comment 20•14 years ago
|
||
Attachment #455926 -
Attachment is obsolete: true
Attachment #461804 -
Flags: review?(bzbarsky)
Assignee | ||
Comment 21•14 years ago
|
||
Attachment #455928 -
Attachment is obsolete: true
Attachment #461805 -
Flags: review?(bzbarsky)
Assignee | ||
Comment 22•14 years ago
|
||
Attachment #455957 -
Attachment is obsolete: true
Attachment #461807 -
Flags: review?(bzbarsky)
Assignee | ||
Comment 23•14 years ago
|
||
Updating for bitrot
Attachment #461798 -
Attachment is obsolete: true
Attachment #468220 -
Flags: review?(bzbarsky)
Attachment #461798 -
Flags: review?(bzbarsky)
Assignee | ||
Comment 24•14 years ago
|
||
Attachment #461800 -
Attachment is obsolete: true
Attachment #468221 -
Flags: review?(bzbarsky)
Attachment #461800 -
Flags: review?(bzbarsky)
Assignee | ||
Comment 25•14 years ago
|
||
Attachment #461803 -
Attachment is obsolete: true
Attachment #468222 -
Flags: review?(bzbarsky)
Attachment #461803 -
Flags: review?(bzbarsky)
Assignee | ||
Comment 26•14 years ago
|
||
Attachment #461804 -
Attachment is obsolete: true
Attachment #468223 -
Flags: review?(bzbarsky)
Attachment #461804 -
Flags: review?(bzbarsky)
Assignee | ||
Comment 27•14 years ago
|
||
Attachment #461805 -
Attachment is obsolete: true
Attachment #468224 -
Flags: review?(bzbarsky)
Attachment #461805 -
Flags: review?(bzbarsky)
Assignee | ||
Comment 28•14 years ago
|
||
Attachment #461807 -
Attachment is obsolete: true
Attachment #468225 -
Flags: review?(bzbarsky)
Attachment #461807 -
Flags: review?(bzbarsky)
Assignee | ||
Comment 29•14 years ago
|
||
Attachment #468220 -
Attachment is obsolete: true
Attachment #518272 -
Flags: review?(bzbarsky)
Attachment #468220 -
Flags: review?(bzbarsky)
Assignee | ||
Comment 30•14 years ago
|
||
Attachment #468221 -
Attachment is obsolete: true
Attachment #518273 -
Flags: review?(bzbarsky)
Attachment #468221 -
Flags: review?(bzbarsky)
Assignee | ||
Comment 31•14 years ago
|
||
Attachment #468222 -
Attachment is obsolete: true
Attachment #518274 -
Flags: review?(bzbarsky)
Attachment #468222 -
Flags: review?(bzbarsky)
Assignee | ||
Comment 32•14 years ago
|
||
Attachment #468223 -
Attachment is obsolete: true
Attachment #518275 -
Flags: review?(bzbarsky)
Attachment #468223 -
Flags: review?(bzbarsky)
Assignee | ||
Comment 33•14 years ago
|
||
Attachment #468224 -
Attachment is obsolete: true
Attachment #518276 -
Flags: review?(bzbarsky)
Attachment #468224 -
Flags: review?(bzbarsky)
Assignee | ||
Comment 34•14 years ago
|
||
Attachment #468225 -
Attachment is obsolete: true
Attachment #518277 -
Flags: review?(bzbarsky)
Attachment #468225 -
Flags: review?(bzbarsky)
Comment 35•14 years ago
|
||
Comment on attachment 518272 [details] [diff] [review]
Part 1: Rename CSSStyleRuleImpl updated to use namespace
r=me
Attachment #518272 -
Flags: review?(bzbarsky) → review+
Comment 36•14 years ago
|
||
Comment on attachment 518273 [details] [diff] [review]
Part 2: rename DOMCSSStyleRuleImpl updated to use namespace.
r=me
Attachment #518273 -
Flags: review?(bzbarsky) → review+
Comment 37•14 years ago
|
||
Comment on attachment 518274 [details] [diff] [review]
Part 3: Rename CSSImportantRule updated to use namespace
r=me
Attachment #518274 -
Flags: review?(bzbarsky) → review+
Comment 38•14 years ago
|
||
Comment on attachment 518276 [details] [diff] [review]
Part 5: Remove virtual from methods that came from nsICSSStyleRule
r=me
Attachment #518276 -
Flags: review?(bzbarsky) → review+
Comment 39•14 years ago
|
||
Comment on attachment 518277 [details] [diff] [review]
Part 6: DeCOMtaminate StyleRule method signatures
r=me
Attachment #518277 -
Flags: review?(bzbarsky) → review+
Comment 40•14 years ago
|
||
Comment on attachment 518275 [details] [diff] [review]
Part 4: Remove nsICSSStyleRule and move StyleRule to header file.
r=me
Attachment #518275 -
Flags: review?(bzbarsky) → review+
Comment 41•14 years ago
|
||
Pushed to birch:
http://hg.mozilla.org/projects/birch/rev/fbce8d3cb670
http://hg.mozilla.org/projects/birch/rev/4cdf2a9fdade
http://hg.mozilla.org/projects/birch/rev/055167d450a9
http://hg.mozilla.org/projects/birch/rev/cbb08a3bd975
http://hg.mozilla.org/projects/birch/rev/bf3db16c8149
http://hg.mozilla.org/projects/birch/rev/281f20a0dacd
Whiteboard: fixed-in-birch
Comment 43•14 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/fbce8d3cb670
https://hg.mozilla.org/mozilla-central/rev/4cdf2a9fdade
https://hg.mozilla.org/mozilla-central/rev/055167d450a9
https://hg.mozilla.org/mozilla-central/rev/cbb08a3bd975
https://hg.mozilla.org/mozilla-central/rev/bf3db16c8149
https://hg.mozilla.org/mozilla-central/rev/281f20a0dacd
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Priority: -- → P4
Resolution: --- → FIXED
Whiteboard: fixed-in-birch
Target Milestone: --- → mozilla2.2
Updated•14 years ago
|
Flags: in-testsuite-
You need to log in
before you can comment on or make changes to this bug.
Description
•