Closed Bug 577222 Opened 14 years ago Closed 14 years ago

Mistyped function name in subscribe.js

Categories

(Firefox :: Bookmarks & History, defect)

Product:
Firefox
Component:
Bookmarks & History
Type:
defect
Priority:
Not set
Severity:
trivial

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 4.0b2

People

(Reporter: brunner.adam, Assigned: mkohler)

References

Details

Attachments

(1 file)

Patch v1 (trivial)
(deleted), patch
asaf
: review+
Details | Diff | Splinter Review 
User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2.6) Gecko/20100625 Firefox/3.6.6
Build Identifier: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2.6) Gecko/20100625 Firefox/3.6.6

Int he file /browser/content/feeds/subscribe.js the "FH_subscribe()" method's name should be "SH_subscribe()" (note the leading 'S') to follow the conventions.

Reproducible: Always
Nice catch.
Assignee: nobody → michaelkohler
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Blocks: 577266
Attached patch Patch v1 (trivial) (deleted) — — Splinter Review 

  

  



        Attachment #456273 -
        Flags: review?(mano)

    
    

    
  
Thanks, wasn't sure that this is a typo or it is by design, did not follow up the whole code :)

  

  



    
  

        Attachment #456273 -
        Flags: review?(mano) → review+

    
  
Keywords: checkin-needed

    
    

    
  
http://hg.mozilla.org/mozilla-central/rev/4b55be4cce6e

  

  


Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.7b2

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: