Closed
Bug 577814
Opened 14 years ago
Closed 14 years ago
Commenting on attachment all throws away comment and quotes attachment instead
Categories
(bugzilla.mozilla.org :: General, defect)
bugzilla.mozilla.org
General
Tracking
()
RESOLVED
WORKSFORME
People
(Reporter: iannbugzilla, Assigned: reed)
References
Details
(Keywords: regression)
Steps to reproduce:
1/ Click on detail for a patch
2/ Type in comment in comment field
3/ Click on submit button
Expected Result
1/ Bug is updated with comment
Actual Result
1/ Bug is updated with attachment as quote, comment isn't shown.
(see https://bugzilla.mozilla.org/show_bug.cgi?id=576900#c28 and https://bugzilla.mozilla.org/show_bug.cgi?id=576900#c29 for examples)
(In reply to comment #0)
> Steps to reproduce:
> 1/ Click on detail for a patch
> 2/ Type in comment in comment field
> 3/ Click on submit button
>
> Expected Result
> 1/ Bug is updated with comment
>
> Actual Result
> 1/ Bug is updated with attachment as quote, comment isn't shown.
> (see https://bugzilla.mozilla.org/show_bug.cgi?id=576900#c28 and
> https://bugzilla.mozilla.org/show_bug.cgi?id=576900#c29 for examples)
Okay, cleared the cache for a 3rd time and it worked (perhaps an ISP cache?)
Comment 2•14 years ago
|
||
WFM per comment 1.
Blocks: bmo-regressions-1007
Status: UNCONFIRMED → RESOLVED
Closed: 14 years ago
No longer depends on: bmo-regressions-1007
Resolution: --- → WORKSFORME
Updated•14 years ago
|
Assignee: attach-and-request → nobody
Component: Attachments & Requests → Bugzilla: Other b.m.o Issues
Product: Bugzilla → mozilla.org
QA Contact: default-qa → other-bmo-issues
Version: 3.6.1 → other
Comment 3•14 years ago
|
||
Reoppening as this has affected me and cdleary at least
Status: RESOLVED → REOPENED
Ever confirmed: true
Resolution: WORKSFORME → ---
Comment 4•14 years ago
|
||
Affected me as well just now, in bug 577905 comment 3.
Assignee | ||
Comment 5•14 years ago
|
||
Callek and dholbert, are you seeing this even after clearing your cache for bmo?
Comment 6•14 years ago
|
||
(In reply to comment #5)
> Callek and dholbert, are you seeing this even after clearing your cache for
> bmo?
*JUST* was lucky enough to verify that after clearing my entire cache I don't encounter this. But as we briefly discussed on IRC, proper E-Tag use and cache invalidation is important to avoid problems. (This just happens to be a very noticeable one)
Comment 7•14 years ago
|
||
I'm open to suggestions for how to do that. I'd love to make it automatic when we upgrade bugzilla, as this has been an issue with the last few upgrades. Cache invalidation sounds kinda hard, as we're not going to know in advance when the files change. ETags on the static files getting cached by the browser should be getting generated by Apache.
Comment 8•14 years ago
|
||
See bug 428313.
Comment 9•14 years ago
|
||
This did indeed seem to become fixed when I cleared my cache[1] and restarted Firefox.
[1] cleared cache via "Tools | Clear Recent History", with:
- Time Range: "everything"
- Details: "Cache" checked, everything else unchecked
(please indicate if there's an easier/better way to selectively clear the bmo cache -- there are people still hitting this bug (someone just brought it up in IRC) who still have caches that need clearing.)
Comment 10•14 years ago
|
||
Note that bug 428313 fixes this for the 4.0 branch of upstream Bugzilla (the branch where the new UI actually went in--it was backported by reed to 3.6 for bmo). JS and CSS files will now be appropriately reloaded by the browser when they change. However, this was a rather significant change that involved a fairly large patch, and has only been tested by the original developer and the reviewer who reviewed the patch.
Assignee | ||
Comment 11•14 years ago
|
||
I'll probably look into testing and eventually backporting bug 428313 to bmo's 3.6 branch. Won't happen for a while, though.
Assignee: nobody → reed
Status: REOPENED → NEW
Comment 12•14 years ago
|
||
Clearing caches has sorted this out for people. And 4.0 will solve the problem permanently. So we might have one more issue with it when we upgrade to 4.0, but not after that.
Gerv
Status: NEW → RESOLVED
Closed: 14 years ago → 14 years ago
Resolution: --- → WORKSFORME
Comment 13•14 years ago
|
||
Only problem is that I have to remember to clear the cache *every* *time* just before changing anything in an attachment and sometimes I forget.
Comment 14•14 years ago
|
||
(In reply to comment #13)
> Only problem is that I have to remember to clear the cache *every* *time* just
> before changing anything in an attachment and sometimes I forget.
That problem is in fact fixed in 4.0.
Updated•13 years ago
|
Component: Bugzilla: Other b.m.o Issues → General
Product: mozilla.org → bugzilla.mozilla.org
You need to log in
before you can comment on or make changes to this bug.
Description
•