Closed
Bug 577820
Opened 14 years ago
Closed 14 years ago
javascript:window.close() does not work if "browser.tabs.closeWindowWithLastTab" set to false
Categories
(Firefox :: Tabbed Browser, defect)
Tracking
()
RESOLVED
DUPLICATE
of bug 583000
People
(Reporter: bugmozz, Unassigned)
References
Details
(Keywords: regression)
Attachments
(1 file)
|
(deleted),
text/html
|
Details |
Mozilla/5.0 (Windows; Windows NT 6.1; en-US; rv:2.0b2pre) Gecko/20100710 Minefield/4.0b2pre ID:20100710040941
sample page : http://www.pcurtis.com/popup.htm
and lacationbar is blank.
Keywords: regression
(In reply to comment #0)
> Mozilla/5.0 (Windows; Windows NT 6.1; en-US; rv:2.0b2pre) Gecko/20100710
> Minefield/4.0b2pre ID:20100710040941
>
>
> sample page : http://www.pcurtis.com/popup.htm
>
> and lacationbar is blank.
[STR]
1) set the pref true/false
2) click image > window open
|
||
Comment 2•14 years ago
|
||
I've just hit this bug too. The window.close() function should not take into account the browser.tabs.closeWindowWithLastTab preference when it deals with popup windows opened by the window.open() function (especially when using toolbar=0 argument).
I'll attach a simple testcase in a minute
pal-moz, you should reclassify this bug into the 'tabbed browser' component.
|
|
||
Comment 3•14 years ago
|
||
Component: General → Tabbed Browser
QA Contact: general → tabbed.browser
|
||
Comment 4•14 years ago
|
||
Regression window:
Works:
http://hg.mozilla.org/mozilla-central/rev/50f755860783
Mozilla/5.0 (Windows; U; Windows NT 6.1; WOW64; en-US; rv:1.9.3a6pre) Gecko/20100623 Minefield/3.7a6pre ID:20100624061215
Fails:
http://hg.mozilla.org/mozilla-central/rev/4a6f3d15cfdc
Mozilla/5.0 (Windows; U; Windows NT 6.1; WOW64; en-US; rv:1.9.3a6pre) Gecko/20100623 Minefield/3.7a6pre ID:20100624095420
Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=50f755860783&tochange=4a6f3d15cfdc
Regression bug:
Bug 571992 - Switch Tabs-on-top to be the Default State on Windows
Errors in console are as follows:
Error: this.browsers[i] is undefined
Source file: chrome://browser/content/tabbrowser.xml
Line: 248
<method name="_getTabForContentWindow">
<parameter name="aWindow"/>
<body>
<![CDATA[
for (let i = 0; i < this.browsers.length; i++) {
>> if (this.browsers[i].contentWindow == aWindow)
return this.tabs[i];
}
return null;
Error: Component returned failure code: 0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsIObserverService.addObserver]
Source file: chrome://browser/content/browser.js
Line: 5229
// Manually hook up session and global history for the first browser
// so that we don't have to load global history before bringing up a
// window.
// Wire up session and global history before any possible
// progress notifications for back/forward button updating
webNavigation.sessionHistory = Components.classes["@mozilla.org/browser/shistory;1"]
.createInstance(Components.interfaces.nsISHistory);
>> Services.obs.addObserver(gBrowser.browsers[0], "browser:purge-session-history", false);
Error: this._privateBrowsingService is null
Source file: chrome://browser/content/browser.js
Line: 11251
get privateBrowsingEnabled() {
>> return this._privateBrowsingService.privateBrowsingEnabled;
}
Error: this.tabs is undefined
Source file: chrome://browser/content/tabbrowser.xml
Line: 1345
if (!animate &&
this._removingTabs.indexOf(aTab) > -1) {
this._endRemoveTab(aTab);
return;
}
>> var isLastTab = (this.tabs.length - this._removingTabs.length == 1);
if (!this._beginRemoveTab(aTab, false, null, true))
return;
Error: win.gTaskbarTabGroup is undefined
Source file: resource://gre/modules/WindowsPreviewPerTab.jsm
Line: 650
Error: (void 0) is undefined
Source file: chrome://browser/content/tabbrowser.xml
Line: 2327
<destructor>
<
|
||
Updated•14 years ago
|
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → DUPLICATE
You need to log in
before you can comment on or make changes to this bug.
Description
•