Closed Bug 578047 Opened 14 years ago Closed 14 years ago

More native look on Vista/Win7 for the aw-menulist

Categories

(Thunderbird :: Message Compose Window, defect)

Product:
Thunderbird
Component:
Message Compose Window
Platform:
x86
Windows 7
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 3.3a1

People

(Reporter: Paenglab, Assigned: Paenglab)

Details

Attachments

(3 files)

Patch to change the appearance of aw-menulist
(deleted), patch
andreasn
: review-
clarkbw
: ui-review+
Details | Diff | Splinter Review
Image showing the difference
(deleted), image/png
Details
unbitrotted patch
(deleted), patch
andreasn
: review+
clarkbw
: ui-review+
Details | Diff | Splinter Review
User-Agent: Mozilla/5.0 (Windows; Windows NT 6.1; de-DE; rv:2.0b2pre) Gecko/20100712 Minefield/4.0b2pre Build Identifier: This patch makes the aw-menulist more native looking than the old WinNT appearance. Reproducible: Always
Is this okay with ui-rewiew @ clarkbw and review @ philringnalda?
Attachment #456865 - Flags: ui-review?(clarkbw)
Attachment #456865 - Flags: review?(philringnalda)
Attached image Image showing the difference (deleted) —
Assignee: nobody → richard.marti
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Comment on attachment 456865 [details] [diff] [review] Patch to change the appearance of aw-menulist Philor is booked a lot these days carying over to Andreas.
Attachment #456865 - Flags: review?(philringnalda) → review?(nisses.mail)
Attached patch unbitrotted patch (deleted) — — Splinter Review
It seems that the patch had bitrotted for some reason, as I couldn't apply it cleanly on trunk. This one should work better.
Comment on attachment 456865 [details] [diff] [review] Patch to change the appearance of aw-menulist Minus on this since I can't get it to apply cleanly. Mark thought it might be related to line endings being wrong. Will give plus on the edit I did however.
Attachment #456865 - Flags: review?(nisses.mail) → review-
Comment on attachment 457050 [details] [diff] [review] unbitrotted patch (not that this is just a edited version of Richards patch that avoids the bitrot) Not sure if the child selector is really needed in this case, but I can't see it do any harm either, so r+ on this.
Attachment #457050 - Flags: ui-review?(clarkbw)
Attachment #457050 - Flags: review+
Comment on attachment 456865 [details] [diff] [review] Patch to change the appearance of aw-menulist looks good
Attachment #456865 - Flags: ui-review?(clarkbw) → ui-review+
Comment on attachment 457050 [details] [diff] [review] unbitrotted patch oh, this is the right one now. Thanks Richard!
Attachment #457050 - Flags: ui-review?(clarkbw) → ui-review+
Checked in: http://hg.mozilla.org/comm-central/rev/b1f196e3f84b
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.2a1
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: