Closed
Bug 578441
Opened 14 years ago
Closed 14 years ago
Use <menupopup> instead of <popup>
Categories
(Thunderbird :: General, defect)
Thunderbird
General
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 3.3a1
People
(Reporter: dao, Assigned: Usul)
References
()
Details
(Whiteboard: [tbtrunkneeded])
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
Usul
:
review+
Usul
:
superreview+
|
Details | Diff | Splinter Review |
Support for <popup> is going away (bug 578322). <popup> has been obsoleted for some time and support was flaky (e.g. bug 571567).
Updated•14 years ago
|
Updated•14 years ago
|
Whiteboard: [tb32needs]
Updated•14 years ago
|
Is it as easy at it seems, that you only need to change all "popup" to "menupopup" in all those xul files from the mxr url (like in bug 571567). If yes, than I can make patch.
Comment 4•14 years ago
|
||
(In reply to comment #3)
> Is it as easy at it seems, that you only need to change all "popup" to
> "menupopup" in all those xul files from the mxr url (like in bug 571567). If
> yes, than I can make patch.
Yes I believe it should be, see also bug 578440 for the suite/ version (you can always just try one or two first and see if it fixes the current popup menu issues).
Assignee | ||
Comment 5•14 years ago
|
||
I'm compiling the patch right now.
(In reply to comment #5)
> I'm compiling the patch right now.
Oh, I'am ready with my patch. Should I upload it anyway?
Assignee | ||
Comment 7•14 years ago
|
||
Standrad8 waht the requirements review wise for the parts in suite/ is asking your enough ?
Assignee: nobody → ludovic
Status: NEW → ASSIGNED
Attachment #458328 -
Flags: superreview?(bugzilla)
Attachment #458328 -
Flags: review?(bugzilla)
Your patch look very similar to mine :-) The only difference is, you didn't realign the onpopup's under the "id", like:
- <popup id="mailContext"
- onpopupshowing="return fillMailContextMenu(event);"
- onpopuphiding="mailContextOnPopupHiding(event);">
+ <menupopup id="mailContext"
+ onpopupshowing="return fillMailContextMenu(event);"
+ onpopuphiding="mailContextOnPopupHiding(event);">
Comment 10•14 years ago
|
||
Comment on attachment 458328 [details] [diff] [review]
patch fixing the issue
This looks fine, but please fix the indentation in multiple places, as per comment 8.
Attachment #458328 -
Flags: superreview?(bugzilla)
Attachment #458328 -
Flags: superreview+
Attachment #458328 -
Flags: review?(bugzilla)
Attachment #458328 -
Flags: review+
Assignee | ||
Comment 11•14 years ago
|
||
Attachment #458328 -
Attachment is obsolete: true
Attachment #459791 -
Flags: superreview+
Attachment #459791 -
Flags: review+
Assignee | ||
Updated•14 years ago
|
Keywords: checkin-needed
Assignee | ||
Comment 12•14 years ago
|
||
(In reply to comment #10)
> Comment on attachment 458328 [details] [diff] [review]
> patch fixing the issue
>
> This looks fine, but please fix the indentation in multiple places, as per
> comment 8.
done
Comment 13•14 years ago
|
||
You missed a couple, but I fixed them on checkin:
http://hg.mozilla.org/comm-central/rev/5e29e16c191b
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.2a1
Updated•14 years ago
|
Whiteboard: [tb32needs] → [tbtrunkneeded]
You need to log in
before you can comment on or make changes to this bug.
Description
•