Closed Bug 578563 Opened 14 years ago Closed 14 years ago

Make objdir builds the default in client.mk

Categories

(Firefox Build System :: General, enhancement)

Product:
Firefox Build System
Component:
General
Platform:
x86
Windows 7
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: khuey, Assigned: khuey)

References

Details

(Keywords: dev-doc-complete)

Attachments

(1 file)

Patch
(deleted), patch
ted
: review+
benjamin
: approval2.0+
Details | Diff | Splinter Review
No description provided.
How? You mean in client.mk? Or if you configure in the srcdir, we would automatically generate an objdir and use that instead?
The plan (as discussed on IRC) was to make it the default in client.mk, and leave configure users to fend for themselves. (Our build docs don't tell you to use configure, IIRC.) This has the nice side effect that people can grab source tarballs and ./configure && make like you would with other projects.
Summary: Make objdir builds the default. → Make objdir builds the default in client.mk
Attached patch Patch (deleted) — — Splinter Review
Assignee: nobody → me
Status: NEW → ASSIGNED
Attachment #466046 - Flags: review?(ted.mielczarek)
Comment on attachment 466046 [details] [diff] [review] Patch Sounds good. Thanks!
Attachment #466046 - Flags: review?(ted.mielczarek) → review+
Attachment #466046 - Flags: approval2.0? → approval2.0+
http://hg.mozilla.org/mozilla-central/rev/2cfcf5515e1b
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Callek, you may be interested in porting this to c-c.
Blocks: 589507
(In reply to comment #6) > Callek, you may be interested in porting this to c-c. We certainly are: Bug 589507
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: