Closed
Bug 578671
Opened 14 years ago
Closed 14 years ago
Sync which engines are enabled across clients, wipe data for disabled engines
Categories
(Firefox :: Sync, defect)
Firefox
Sync
Tracking
()
RESOLVED
FIXED
1.6
People
(Reporter: philikon, Assigned: philikon)
References
(Depends on 1 open bug)
Details
Attachments
(2 files)
(deleted),
patch
|
mconnor
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
mconnor
:
review+
|
Details | Diff | Splinter Review |
The choice which engines to sync (engine.enabled) should affect all clients, not just the one you're making the choice on. Once a particular engine is disabled, its data should also be wiped on the server.
Engine.enabled is persisted as a preference, but since the preference engine could be disabled just as well, we can't really use it to sync that info. The meta/global WBO seems like a good place (inside the 'engines' hash) since it's checked before every sync anyway.
Comment 1•14 years ago
|
||
Bug 563459 is probably related.
Assignee | ||
Comment 2•14 years ago
|
||
Yes, syncing which engines are enabled implies prepopulating those checkboxes.
Updated•14 years ago
|
Target Milestone: --- → 1.6
Assignee | ||
Comment 4•14 years ago
|
||
Observe and remember when the engine enabled prefs change. Upon the next sync, check for newly enabled or disabled engines both remotely and locally. Presence in meta/global's engines object is interpreted as being enabled.
Assignee: nobody → philipp
Attachment #472491 -
Flags: review?(mconnor)
Updated•14 years ago
|
Attachment #472491 -
Flags: review?(mconnor) → review+
Assignee | ||
Comment 5•14 years ago
|
||
Change strings to indicate that the engine setting is no longer contained to each individual computer.
Attachment #472643 -
Flags: review?(mconnor)
Updated•14 years ago
|
Attachment #472643 -
Flags: review?(mconnor) → review+
Assignee | ||
Comment 6•14 years ago
|
||
http://hg.mozilla.org/services/fx-sync/rev/5571f5038b93
http://hg.mozilla.org/services/fx-sync/rev/9bd8a5592b2f
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Comment 7•14 years ago
|
||
I was recently playing with this on Minefield and noticed that I didn't get any message saying whether pre-existing data on the server will be deleted or if it will remain there? I think we should let users know what happens as it is not immediately obvious.
Comment 8•14 years ago
|
||
Please file a followup on that and we can discuss it in that bug?
Comment 9•14 years ago
|
||
Updated•6 years ago
|
Component: Firefox Sync: Backend → Sync
Product: Cloud Services → Firefox
You need to log in
before you can comment on or make changes to this bug.
Description
•