Closed Bug 578671 Opened 14 years ago Closed 14 years ago

Sync which engines are enabled across clients, wipe data for disabled engines

Categories

(Firefox :: Sync, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: philikon, Assigned: philikon)

References

(Depends on 1 open bug)

Details

Attachments

(2 files)

The choice which engines to sync (engine.enabled) should affect all clients, not just the one you're making the choice on. Once a particular engine is disabled, its data should also be wiped on the server. Engine.enabled is persisted as a preference, but since the preference engine could be disabled just as well, we can't really use it to sync that info. The meta/global WBO seems like a good place (inside the 'engines' hash) since it's checked before every sync anyway.
Bug 563459 is probably related.
Yes, syncing which engines are enabled implies prepopulating those checkboxes.
Target Milestone: --- → 1.6
Blocks: 592375
Blocks: 563459
Attached patch v1 (deleted) — Splinter Review
Observe and remember when the engine enabled prefs change. Upon the next sync, check for newly enabled or disabled engines both remotely and locally. Presence in meta/global's engines object is interpreted as being enabled.
Assignee: nobody → philipp
Attachment #472491 - Flags: review?(mconnor)
Blocks: 590633
Attachment #472491 - Flags: review?(mconnor) → review+
Attached patch strings v1 (deleted) — Splinter Review
Change strings to indicate that the engine setting is no longer contained to each individual computer.
Attachment #472643 - Flags: review?(mconnor)
Attachment #472643 - Flags: review?(mconnor) → review+
No longer blocks: 590633
Blocks: 594241
Blocks: 594506
Blocks: 594785
I was recently playing with this on Minefield and noticed that I didn't get any message saying whether pre-existing data on the server will be deleted or if it will remain there? I think we should let users know what happens as it is not immediately obvious.
Please file a followup on that and we can discuss it in that bug?
Depends on: 1182397
Depends on: 1345345
Component: Firefox Sync: Backend → Sync
Product: Cloud Services → Firefox
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: